Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkp/pkp-lib#7188] Adds number of user assignments on user assignment grid #10800

Open
wants to merge 1 commit into
base: stable-3_4_0
Choose a base branch
from

Conversation

JhonathanLepidus
Copy link
Contributor

Related to issue 7188.

Signed-off-by: Jhon <jhon@lepidus.com.br>
Copy link
Member

@asmecher asmecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JhonathanLepidus, I think this will unintentionally/unexpectedly affect the SubscriberSelectGridHandler class, which is a subclass of UserSelectGridHandler. It should only affect the participant assignment area.

@JhonathanLepidus
Copy link
Contributor Author

Hi @asmecher , I checked this possible conflict and, luckily, it does not affect the SubscriberSelectGridHandler. This class inherits directly from GridHandler. However, it uses the class UserSelectGridCellProvider, but since it doesn't add the assignments column, it's not affected by the new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants