Thread sanitization, GCD best practices

pixel-foundry · Mar 21, 2021 · 3c85ebd · 3c85ebd
1 parent ff3c0f1
commit 3c85ebd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/Sources/RemoteImageDimensions/RemoteImageDataDelegate.swift b/Sources/RemoteImageDimensions/RemoteImageDataDelegate.swift
@@ -5,9 +5,15 @@ import FoundationNetworking
 
 final class RemoteImageDataDelegate: NSObject, URLSessionDataDelegate {
 
-	private let queue = DispatchQueue(label: "RemoteImageDataDelegateQueue", qos: .utility)
+	private let queue = DispatchQueue(label: "RemoteImageDataDelegateQueue", target: DispatchQueue.global())
 
-	var taskDelegates = [ImageDimensionTaskDelegate]()
+	private var taskDelegates: [ImageDimensionTaskDelegate] = []
+
+	func addTaskDelegate(_ delegate: ImageDimensionTaskDelegate) {
+		queue.async {
+			self.taskDelegates.append(delegate)
+		}
+	}
 
 	func urlSession(_ session: URLSession, dataTask: URLSessionDataTask, didReceive data: Data) {
 		queue.async {

diff --git a/Sources/RemoteImageDimensions/RemoteImageDimensions.swift b/Sources/RemoteImageDimensions/RemoteImageDimensions.swift
@@ -28,7 +28,7 @@ public enum RemoteImage {
 	) -> RemoteImageDimensionsTask {
 		let dataTask = urlSession.dataTask(with: URLRequest.request(for: image, with: configuration))
 		let taskDelegate = ImageDimensionTaskDelegate(task: dataTask, completion)
-		delegate.taskDelegates.append(taskDelegate)
+		delegate.addTaskDelegate(taskDelegate)
 		dataTask.resume()
 		return RemoteImageDimensionsTask(cancel: { [weak taskDelegate, weak delegate] in
 			taskDelegate?.cancel()