Map errors to exceptions #1764
Merged
Map errors to exceptions #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osoriano
reviewed
Dec 10, 2024
deploy-service/universal/src/main/java/com/pinterest/teletraan/universal/http/HttpClient.java
Outdated
Show resolved
Hide resolved
osoriano
previously approved these changes
Dec 10, 2024
osoriano
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map WebApplicationException to more detailed subclasses, this is helpful for Rodimus adoption of this HttpClient implementation. Additionally, making
callTimeoutconfigurable and replacing existingreadTimeoutandconnectTimeout. It's needed by Rodimus and it's easier to control 1 then 2.Lastly, there is a leak in the constructor. It's now moved to the static init block.