-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous Integration/ROS Noetic Compatibility #52
base: master
Are you sure you want to change the base?
Conversation
This PR may not start a build until it gets merged into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is an excellent improvement, it formalizes the installation process of PhoXiControl for Kinetic, Melodic and Noetic.
There are minor modifications that could be done on top of this PR:
- use a single installer script (there are 2 used currently, 1 for Kinetic and 1 for Melodic/Noetic)
- merge common code
- extend with deeper versioning (not only for 1.2.14 support)
But this can be done as a separate PR as well and we could merge this into the master
.
Overall, this is a welcome and beneficial addition to the repository.
Thank you, @marip8
Note: please follow the official support website for PhoXiControl, it is advised to only use supported operating systems with PXC. |
This PR adds Github Actions Continuous Integration (CI) to ensure the repository builds for ROS Kinetic, Melodic, and Noetic. CI is configured to run for pull requests against the
master
branch, when changes are pushed to themaster
branch, and on a weekly basis (to catch breakage from dependency changes). Currently the unit tests are disabled in the CI process because the machine running the CI build is not connected to a Photoneo scanner which is required by the tests.This PR also compiles the package with C++ 14 for compatibility with PCL 1.10 which is the default version for ROS Noetic.