Update PangolinMQTT.cpp #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment out Serial object print. ? change it to PANGO_PRINT I note philbowles#8 Is there a reason that the https://github.com/philbowles/PangolinMQTT/blob/300d2b38689f66db6344da2488ea429116555ef5/src/PANGO.cpp#L204 Could not be changed to ```cpp void PANGO::dumphex(Print & output, uint8_t* mem, size_t len,uint8_t W) ``` and forgo any dependance on `Serial` all together. I also do not have a Serial Object for most of my projects and output debugging over a telnet interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment out Serial object print. ? change it to PANGO_PRINT
I note #8
Is there a reason that the
PangolinMQTT/src/PANGO.cpp
Line 204 in 300d2b3
Could also not be changed to
and forgo any dependance on
Serialall together. I also do not have a Serial Object for most of my projects and output debugging over a telnet interface. I also use the Serial interface for communication with other devices, ie PJON so printing to it corrupts that communication. I can of course comment out the lines and roll my ownhexdump but that means changing it every pull.