-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion to implement GitHub Actions #19
Conversation
if [[ $(echo "$version < $PGTARGET" | bc) -eq 1 ]]; then | ||
test_run "$version" "$PGTARGET" | ||
fi | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's a better approach rather than my copy-and-edit one so far. 😄
Cool! Looks like you're putting solid time and effort into getting that working @andyundso. If I send you a team invite so you can do stuff in the repo directly, would that be useful? I'm thinking it'll let you make changes to get things working without me needing to be a gatekeeper (I'm kind of knocking myself out on another project atm 😉). Actually, I just sent an invite anyway so feel free to accept it if it's of interest. 😄 |
had a look and thanks for this awesome work 😊 looks fine to me so far overall it could be an option to use github instead of dockerhub if using Dockerhub @justinclift you need to enter your Dockerhub credentials in this repo. |
@wuast94 Thanks. I've just added a |
thanks for the feedback, I also accepted the invite for the organization. I'll create a new branch directly in the repository to address the remaining points. |
uses: docker/build-push-action@v5 | ||
with: | ||
push: true | ||
platforms: linux/amd64,linux/arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears the Postgres base container supports all of the following architectures: linux/amd64, linux/arm32v5, linux/arm32v6, linux/arm32v7, linux/arm64v8, linux/i386, linux/mips64le, linux/ppc64le, and linux/s390x... so why not go buck wild and support them all? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we might as well give it a shot and see how it goes.
@andyundso You up for that? (maybe later, after you're happy with the other bits? 😄)
Looks fantastic to me! Thanks for doing this. :) |
replaced by #26. |
The last feedback on #14 was that multi-arch images would be desired. This PR contains a GitHub Actions configuration that can build a multi-arch version of the
pgautoupgrade
container. In a nutshell:build
step should be cached.Example workflow run and result on my Docker Hub page.
At this point, I would consider this a WIP, as the following points need to be clarified.
simpliandy/pgautoupgrade
to test things, this needs to be reverted.main
. The-dev
could be pushed when manually starting a run of the workflow from any branch not namedmain
.test.sh
file.