Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduler-utils): trim trailing slash from returned URLs #246 #887

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jrdn91
Copy link
Contributor

@jrdn91 jrdn91 commented Jul 17, 2024

closes #246

adds a trimTrailingSlash function with a test to trim the trailing slash from the URL if it has one.

Wraps the URL returned from both raw and locate function return values.

@jrdn91 jrdn91 requested a review from TillaTheHun0 July 17, 2024 15:29
@jrdn91 jrdn91 force-pushed the jrdn91/trim-trailing-slash-scheduler-utils branch from e0d1266 to 19a04cd Compare July 17, 2024 19:06
@jrdn91 jrdn91 force-pushed the jrdn91/trim-trailing-slash-scheduler-utils branch from 19a04cd to ecb97a6 Compare July 17, 2024 19:34
Copy link
Member

@TillaTheHun0 TillaTheHun0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jrdn91 jrdn91 merged commit 496b5e6 into main Jul 17, 2024
4 checks passed
@jrdn91 jrdn91 deleted the jrdn91/trim-trailing-slash-scheduler-utils branch July 17, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scheduler-utils: trim trailing slash from Url if it exists
2 participants