feat(cu): implement hash chain validation on messages received from SU #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TillaTheHun0
force-pushed
the
tillathehun0/cu-hashchain-validation
branch
from
a7dac85 to
a87db6a
Compare
|
The requirements have changes, and thus requires a different approach. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1112
This PR implements hash chain validation in the CU as described in #1112.
The implementation accommodates the SU changes portion, to include the
previous_assignmentportion of the response, not yet being rolled out. In this case, the CU skips it's hash chain validation. In other words, the CU's hashchain validation is feature flagged, such to only be turned on when the SU changes are live. This enables flexible deployment of either unit -- the CU before the SU or vice-versa