Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add composer support #269

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from
Open

add composer support #269

wants to merge 5 commits into from

Conversation

MDevster
Copy link

No description provided.

@martijngastkemper
Copy link
Collaborator

Can you explain why it would be useful to have Composer support. It's a PHP dependency manager, why loading Javascript with it?

@MDevster
Copy link
Author

MDevster commented Aug 1, 2017

We are currently developing a social feed module for the content management system Contao and want to use your jQuery plugin for the presentation. Since Contao 4, the extensions are only made available via Composer or via a special Contao Manager. We would not have to include the additional Javascripts in our bundle, we could simply define the dependencies. See project composer.json (now is forked)

@martijngastkemper
Copy link
Collaborator

I still don't see a way Composer is useful for Javascript sources, but I'm willing to merge the PR. Can you change the package name back to pavelk2/social-feed. The name will match the repo and it's more easy to find it in Packagist.

fix for pavelk2#309 This is because we use strict mode and under strict deleting a variable name is invalid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants