Skip to content

Commit

Permalink
Update PHP to 8.4
Browse files Browse the repository at this point in the history
  • Loading branch information
ottaviano committed Jan 3, 2025
1 parent ee974d8 commit 94a424e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ env:
TAG: ${{ github.ref_name }}

NODE_VERSION: 18.x
PHP_VERSION: 8.3.7
PHP_VERSION: 8.4

REGISTRY: ${{ secrets.GCP_HOST_GCR }}/${{ secrets.GCP_REGISTRY_PROJECT_ID }}/${{ secrets.REGISTRY_NAME }}
REGISTRY_HOST: ${{ secrets.GCP_HOST_GCR }}
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

ARG CADDY_VERSION=2
# Fix the version of PHP to avoid this bug https://github.com/php/php-src/issues/14480
ARG PHP_VERSION=8.3.7
ARG PHP_VERSION=8.4
ARG NODE_VERSION=18

FROM node:${NODE_VERSION}-alpine AS node
Expand Down

0 comments on commit 94a424e

Please sign in to comment.