Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand HydraDX -> Hydration #218

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Rebrand HydraDX -> Hydration #218

merged 2 commits into from
Aug 13, 2024

Conversation

jak-pan
Copy link
Contributor

@jak-pan jak-pan commented Aug 6, 2024

Rebranded HydraDX to Hydration and added hydration chain to keep the compatibility

Rebranded HydraDX to Hydration and added hydration chain to keep the compatibility
@bkchr
Copy link
Member

bkchr commented Aug 12, 2024

I don't think we support duplicate ids.

@jak-pan
Copy link
Contributor Author

jak-pan commented Aug 12, 2024

I don't think we support duplicate ids.

Hm... Okay... Can we just kill this with fire?

@bkchr
Copy link
Member

bkchr commented Aug 12, 2024

Hm... Okay... Can we just kill this with fire?

Probably. Not sure if anyone (probably someone) is using this network field.

@jak-pan
Copy link
Contributor Author

jak-pan commented Aug 12, 2024

Hm... Okay... Can we just kill this with fire?

Probably. Not sure if anyone (probably someone) is using this network field.

It's mapped to the genesis hash by network field AFAIK... So things like Vault? We didn't rename this for this reason yet, that's why I made copy in the beginning to prepare to rename it but I guess we'll be stuck with it...

@bkchr bkchr merged commit 4f9590d into paritytech:main Aug 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants