Increase the number of pvf execute workers #7116
Open
+3
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
sandreim
approved these changes
Jan 10, 2025
eskimor
reviewed
Jan 10, 2025
| ), | ||
| // Default execution workers is 4 because we have 8 cores on the reference hardware, | ||
| // and this accounts for 50% of that cpu capacity. | ||
| pvf_execute_workers_max_num: execute_workers_max_num.unwrap_or(4), |
There was a problem hiding this comment.
Do we maybe want to limit this to Kusama first?
There was a problem hiding this comment.
I'm fine both ways, what do you think @sandreim ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference hardware requirements have been bumped to at least 8 cores so we can no allocate 50% of that capacity to PVF execution.