Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-functional signature 2.1 -> 2.2 change detailed here: https://github.com/RustCrypto/traits/blob/master/signature/CHANGELOG.md
and the ecdsa version bump is just loosening the requirement on signature:
https://github.com/RustCrypto/signatures/blob/master/ecdsa/CHANGELOG.md
(We could just bump
ecdsa
crate so it can resolve and work with signature 2.2 without being forced to, but the signature 2.2 change looks like a low risk change we should pick up.)Not sure if it's PRdoc-worthy?