-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement NetworkRequest for litep2p #7073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also enable the litep2p request-response benchmark in substrate/client/network/benches/request_response_protocol.rs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, I just didn't want to mix it in one PR
/cmd prdoc --help |
Command help:
|
/cmd prdoc --audience node_dev --bump patch |
Description
Implements NetworkRequest::request for litep2p that we need for networking benchmarks
Review Notes
Duplicates implementation for NetworkService
polkadot-sdk/substrate/client/network/src/service.rs
Lines 1186 to 1205 in 5bf9dd2