feat(wasm-builder): add support for new `wasm32v1-none` target #7008

StackOverflowExcept1on · 2024-12-27T12:45:45Z

Description

Resolves #5777

Previously wasm-builder used hacks such as -Zbuild-std (required rust-src component) and RUSTC_BOOTSTRAP=1 to build WASM runtime without WASM features: sign-ext, multivalue and reference-types, but since Rust 1.84 (will be stable on 9 January, 2025) the situation has improved as there is new wasm32v1-none target that disables all "post-MVP" WASM features except mutable-globals.

Previously, your rust-toolchain.toml looked like this:

[toolchain]
channel = "stable"
components = ["rust-src"]
targets = ["wasm32-unknown-unknown"]
profile = "default"

It should now be updated to something like this:

[toolchain]
channel = "stable"
targets = ["wasm32v1-none"]
profile = "default"

To build the runtime:

cargo build --package minimal-template-runtime --release

Integration

If you are using Rust 1.84 and above, then install the wasm32v1-none target instead of wasm32-unknown-unknown as shown above. You can also remove the unnecessary rust-src component.

Also note the slight differences in conditional compilation:

wasm32-unknown-unknown: #[cfg(all(target_family = "wasm", target_os = "unknown"))]
wasm32v1-none: #[cfg(all(target_family = "wasm", target_os = "none"))]

Avoid using target_os = "unknown" in #[cfg(...)] or #[cfg_attr(...)] and instead use target_family = "wasm" or target_arch = "wasm32" in the runtime code.

Review Notes

Wasm builder requires the following prerequisites for building the WASM binary:

Rust >= 1.68 and Rust < 1.84:
- wasm32-unknown-unknown target
- rust-src component
Rust >= 1.84:
- wasm32v1-none target
- no more -Zbuild-std and RUSTC_BOOTSTRAP=1 hacks and rust-src component requirements!

github-actions · 2024-12-27T19:24:12Z

Review required! Latest push from author must always be reviewed

prdoc/pr_7008.prdoc

StackOverflowExcept1on · 2025-01-02T13:28:54Z

How do I pass CI checks like SemVer and other?

jasl · 2025-01-08T15:44:56Z

Ping @bkchr It seems the CI won't trigger.

jasl · 2025-01-08T17:06:42Z

@StackOverflowExcept1on https://github.com/paritytech/polkadot-sdk/actions/runs/12674781431/job/35324397805?pr=7008 This required CI failed, could you fix it?

StackOverflowExcept1on · 2025-01-08T17:10:59Z

@jasl @bkchr I'll fix that in the next 30 minutes. Also wondering if we'll have to update the runners tomorrow, since the new version 1.84 will be stable tomorrow. I mean that the wasm32-unknown-unknown target should be replaced by wasm32v1-none on runners. We should come to something one on CI. Perhaps we should also replace all occurrences of “wasm32-unknown-unknown”.

jasl · 2025-01-08T17:39:13Z

@jasl @bkchr I'll fix that in the next 30 minutes. Also wondering if we'll have to update the runners tomorrow, since the new version 1.84 will be stable tomorrow. I mean that the wasm32-unknown-unknown target should be replaced by wasm32v1-none on runners. We should come to something one on CI. Perhaps we should also replace all occurrences of “wasm32-unknown-unknown”.

I'm not Parity staff, so I don't know...
I remember there was a critical accident in history by updating the Rust version, so I propose we not update CI.
Let Parity guys update their facilities.

bkchr · 2025-01-08T18:54:15Z

Actually I realized something, @StackOverflowExcept1on can we change the pr to make the new target optional? So, it should still accept the wasm32-unknown-unknown target, but print some warning.

StackOverflowExcept1on · 2025-01-08T18:57:46Z

@bkchr For now, do you want to use an environment variable like FORCE_NEW_WASM_TARGET to switch to wasm32v1-none and remove the warning?

jasl · 2025-01-08T19:03:45Z

Several required CI checks fail. Maybe the latest patch has trouble

StackOverflowExcept1on · 2025-01-08T19:21:24Z

@jasl I think it's some kind of problem with std hitting wasmv1-none (it doesn't support it). It may have happened after recent merge of master.

StackOverflowExcept1on · 2025-01-08T19:37:35Z

It's probably because of #5010. As I wrote above wasm32v1-none does not support std, and wasm32-unknown-unknown has std with stubs.

jasl · 2025-01-08T19:41:08Z

@StackOverflowExcept1on
I don't think so. That PR merged last year in July. Perhaps #7043

StackOverflowExcept1on · 2025-01-08T19:46:41Z

I think this is because wasm32-unknown-unknown has some stubs like BTreeMap<K, V> and others, but the unit tests should probably also have no_std?

polkadot-sdk/substrate/primitives/runtime/src/proving_trie/base16.rs

Lines 195 to 200 in c139739

    
           #[cfg(test)] 
        
           mod tests { 
        
           	use super::*; 
        
           	use crate::traits::BlakeTwo256; 
        
           	use sp_core::H256; 
        
           	use std::collections::BTreeMap;

jasl · 2025-01-08T19:53:37Z

I think this is because wasm32-unknown-unknown has some stubs like BTreeMap<K, V> and others, but the unit tests should probably also have no_std?

polkadot-sdk/substrate/primitives/runtime/src/proving_trie/base16.rs

Lines 195 to 200 in c139739

#[cfg(test)]

mod tests {

use super::*;

use crate::traits::BlakeTwo256;

use sp_core::H256;

use std::collections::BTreeMap;

In my knowledge, all tests should be run with std Substrate doesn't run any test in WASM env

bkchr · 2025-01-08T21:05:18Z

@bkchr For now, do you want to use an environment variable like FORCE_NEW_WASM_TARGET to switch to wasm32v1-none and remove the warning?

No. Just check for the available targets (I think we already have code for that) and then use the new target if available. If the new target is not available, print a warning to the build output.

StackOverflowExcept1on · 2025-01-08T21:05:50Z

@jasl commit 4c3b0ea caused this problem, but I don't know why. I just accepted the changes that were in that log:

@StackOverflowExcept1on https://github.com/paritytech/polkadot-sdk/actions/runs/12674781431/job/35324397805?pr=7008 This required CI failed, could you fix it?

This reverts commit 4c3b0ea.

jasl · 2025-01-09T01:04:44Z

@jasl commit 4c3b0ea caused this problem, but I don't know why. I just accepted the changes that were in that log:

@StackOverflowExcept1on https://github.com/paritytech/polkadot-sdk/actions/runs/12674781431/job/35324397805?pr=7008 This required CI failed, could you fix it?

I think the change that CI gave you is incorrect. I just did a quick character length comparison, 5553 vs 5580, and 3825 vs 3799
There must something different inside the change.

jasl · 2025-01-09T01:14:24Z

I do a quick diff

-node = ["asset-test-utils", "bridge-hub-test-utils", "cumulus-client-cli", "cumulus-client-collator", "cumulus-client-consensus-aura", "cumulus-client-consensus-common", "cumulus-client-consensus-proposer", "cumulus-client-consensus-relay-chain", "cumulus-client-network", "cumulus-client-parachain-inherent", "cumulus-client-pov-recovery", "cumulus-client-service", "cumulus-relay-chain-inprocess-interface", "cumulus-relay-chain-interface", "cumulus-relay-chain-minimal-node", "cumulus-relay-chain-rpc-interface", "cumulus-test-relay-sproof-builder", "emulated-integration-tests-common", "fork-tree", "frame-benchmarking-cli", "frame-remote-externalities", "frame-support-procedural-tools", "generate-bags", "mmr-gadget", "mmr-rpc", "pallet-contracts-mock-network", "pallet-revive-eth-rpc", "pallet-revive-mock-network", "pallet-transaction-payment-rpc", "parachains-runtimes-test-utils", "polkadot-approval-distribution", "polkadot-availability-bitfield-distribution", "polkadot-availability-distribution", "polkadot-availability-recovery", "polkadot-cli", "polkadot-collator-protocol", "polkadot-dispute-distribution", "polkadot-erasure-coding", "polkadot-gossip-support", "polkadot-network-bridge", "polkadot-node-collation-generation", "polkadot-node-core-approval-voting", "polkadot-node-core-approval-voting-parallel", "polkadot-node-core-av-store", "polkadot-node-core-backing", "polkadot-node-core-bitfield-signing", "polkadot-node-core-candidate-validation", "polkadot-node-core-chain-api", "polkadot-node-core-chain-selection", "polkadot-node-core-dispute-coordinator", "polkadot-node-core-parachains-inherent", "polkadot-node-core-prospective-parachains", "polkadot-node-core-provisioner", "polkadot-node-core-pvf", "polkadot-node-core-pvf-checker", "polkadot-node-core-pvf-common", "polkadot-node-core-pvf-execute-worker", "polkadot-node-core-pvf-prepare-worker", "polkadot-node-core-runtime-api", "polkadot-node-metrics", "polkadot-node-network-protocol", "polkadot-node-primitives", "polkadot-node-subsystem", "polkadot-node-subsystem-types", "polkadot-node-subsystem-util", "polkadot-omni-node-lib", "polkadot-overseer", "polkadot-rpc", "polkadot-service", "polkadot-statement-distribution", "polkadot-statement-table", "sc-allocator", "sc-authority-discovery", "sc-basic-authorship", "sc-block-builder", "sc-chain-spec", "sc-cli", "sc-client-api", "sc-client-db", "sc-consensus", "sc-consensus-aura", "sc-consensus-babe", "sc-consensus-babe-rpc", "sc-consensus-beefy", "sc-consensus-beefy-rpc", "sc-consensus-epochs", "sc-consensus-grandpa", "sc-consensus-grandpa-rpc", "sc-consensus-manual-seal", "sc-consensus-pow", "sc-consensus-slots", "sc-executor", "sc-executor-common", "sc-executor-polkavm", "sc-executor-wasmtime", "sc-informant", "sc-keystore", "sc-mixnet", "sc-network", "sc-network-common", "sc-network-gossip", "sc-network-light", "sc-network-statement", "sc-network-sync", "sc-network-transactions", "sc-network-types", "sc-offchain", "sc-proposer-metrics", "sc-rpc", "sc-rpc-api", "sc-rpc-server", "sc-rpc-spec-v2", "sc-runtime-utilities", "sc-service", "sc-state-db", "sc-statement-store", "sc-storage-monitor", "sc-sync-state-rpc", "sc-sysinfo", "sc-telemetry", "sc-tracing", "sc-transaction-pool", "sc-transaction-pool-api", "sc-utils", "snowbridge-runtime-test-common", "sp-blockchain", "sp-consensus", "sp-core-hashing", "sp-core-hashing-proc-macro", "sp-database", "sp-maybe-compressed-blob", "sp-panic-handler", "sp-rpc", "staging-chain-spec-builder", "staging-node-inspect", "staging-tracking-allocator", "std", "subkey", "substrate-build-script-utils", "substrate-frame-rpc-support", "substrate-frame-rpc-system", "substrate-prometheus-endpoint", "substrate-rpc-client", "substrate-state-trie-migration-rpc", "substrate-wasm-builder", "tracing-gum", "xcm-emulator", "xcm-simulator"]
+node = ["asset-test-utils", "bridge-hub-test-utils", "cumulus-client-cli", "cumulus-client-collator", "cumulus-client-consensus-aura", "cumulus-client-consensus-common", "cumulus-client-consensus-proposer", "cumulus-client-consensus-relay-chain", "cumulus-client-network", "cumulus-client-parachain-inherent", "cumulus-client-pov-recovery", "cumulus-client-service", "cumulus-relay-chain-inprocess-interface", "cumulus-relay-chain-interface", "cumulus-relay-chain-minimal-node", "cumulus-relay-chain-rpc-interface", "cumulus-test-relay-sproof-builder", "emulated-integration-tests-common", "fork-tree", "frame-benchmarking-cli", "frame-remote-externalities", "frame-support-procedural-tools", "generate-bags", "mmr-gadget", "mmr-rpc", "pallet-contracts-mock-network", "pallet-revive-eth-rpc", "pallet-revive-mock-network", "pallet-transaction-payment-rpc", "parachains-runtimes-test-utils", "polkadot-approval-distribution", "polkadot-availability-bitfield-distribution", "polkadot-availability-distribution", "polkadot-availability-recovery", "polkadot-cli", "polkadot-collator-protocol", "polkadot-dispute-distribution", "polkadot-erasure-coding", "polkadot-gossip-support", "polkadot-network-bridge", "polkadot-node-collation-generation", "polkadot-node-core-approval-voting", "polkadot-node-core-approval-voting-parallel", "polkadot-node-core-av-store", "polkadot-node-core-backing", "polkadot-node-core-bitfield-signing", "polkadot-node-core-candidate-validation", "polkadot-node-core-chain-api", "polkadot-node-core-chain-selection", "polkadot-node-core-dispute-coordinator", "polkadot-node-core-parachains-inherent", "polkadot-node-core-prospective-parachains", "polkadot-node-core-provisioner", "polkadot-node-core-pvf", "polkadot-node-core-pvf-checker", "polkadot-node-core-pvf-common", "polkadot-node-core-pvf-execute-worker", "polkadot-node-core-pvf-prepare-worker", "polkadot-node-core-runtime-api", "polkadot-node-metrics", "polkadot-node-network-protocol", "polkadot-node-primitives", "polkadot-node-subsystem", "polkadot-node-subsystem-types", "polkadot-node-subsystem-util", "polkadot-omni-node-lib", "polkadot-overseer", "polkadot-rpc", "polkadot-service", "polkadot-statement-distribution", "polkadot-statement-table", "sc-allocator", "sc-authority-discovery", "sc-basic-authorship", "sc-block-builder", "sc-chain-spec", "sc-cli", "sc-client-api", "sc-client-db", "sc-consensus", "sc-consensus-aura", "sc-consensus-babe", "sc-consensus-babe-rpc", "sc-consensus-beefy", "sc-consensus-beefy-rpc", "sc-consensus-epochs", "sc-consensus-grandpa", "sc-consensus-grandpa-rpc", "sc-consensus-manual-seal", "sc-consensus-pow", "sc-consensus-slots", "sc-executor", "sc-executor-common", "sc-executor-polkavm", "sc-executor-wasmtime", "sc-informant", "sc-keystore", "sc-mixnet", "sc-network", "sc-network-common", "sc-network-gossip", "sc-network-light", "sc-network-statement", "sc-network-sync", "sc-network-transactions", "sc-network-types", "sc-offchain", "sc-proposer-metrics", "sc-rpc", "sc-rpc-api", "sc-rpc-server", "sc-rpc-spec-v2", "sc-runtime-utilities", "sc-service", "sc-state-db", "sc-statement-store", "sc-storage-monitor", "sc-sync-state-rpc", "sc-sysinfo", "sc-telemetry", "sc-tracing", "sc-transaction-pool", "sc-transaction-pool-api", "sc-utils", "snowbridge-runtime-test-common", "sp-blockchain", "sp-consensus", "sp-core-hashing", "sp-core-hashing-proc-macro", "sp-database", "sp-maybe-compressed-blob", "sp-panic-handler", "sp-rpc", "staging-chain-spec-builder", "staging-node-inspect", "staging-tracking-allocator", "std", "subkey", "substrate-build-script-utils", "substrate-frame-rpc-support", "substrate-frame-rpc-system", "substrate-prometheus-endpoint", "substrate-rpc-client", "substrate-state-trie-migration-rpc", "tracing-gum", "xcm-emulator", "xcm-simulator"]

the suggest change miss substrate-wasm-builder

-runtime-full = ["assets-common", "binary-merkle-tree", "bp-header-chain", "bp-messages", "bp-parachains", "bp-polkadot", "bp-polkadot-core", "bp-relayers", "bp-runtime", "bp-test-utils", "bp-xcm-bridge-hub", "bp-xcm-bridge-hub-router", "bridge-hub-common", "bridge-runtime-common", "cumulus-pallet-aura-ext", "cumulus-pallet-dmp-queue", "cumulus-pallet-parachain-system", "cumulus-pallet-parachain-system-proc-macro", "cumulus-pallet-session-benchmarking", "cumulus-pallet-solo-to-para", "cumulus-pallet-weight-reclaim", "cumulus-pallet-xcm", "cumulus-pallet-xcmp-queue", "cumulus-ping", "cumulus-primitives-aura", "cumulus-primitives-core", "cumulus-primitives-parachain-inherent", "cumulus-primitives-proof-size-hostfunction", "cumulus-primitives-storage-weight-reclaim", "cumulus-primitives-timestamp", "cumulus-primitives-utility", "frame-benchmarking", "frame-benchmarking-pallet-pov", "frame-election-provider-solution-type", "frame-election-provider-support", "frame-executive", "frame-metadata-hash-extension", "frame-support", "frame-support-procedural", "frame-support-procedural-tools-derive", "frame-system", "frame-system-benchmarking", "frame-system-rpc-runtime-api", "frame-try-runtime", "pallet-alliance", "pallet-asset-conversion", "pallet-asset-conversion-ops", "pallet-asset-conversion-tx-payment", "pallet-asset-rate", "pallet-asset-tx-payment", "pallet-assets", "pallet-assets-freezer", "pallet-atomic-swap", "pallet-aura", "pallet-authority-discovery", "pallet-authorship", "pallet-babe", "pallet-bags-list", "pallet-balances", "pallet-beefy", "pallet-beefy-mmr", "pallet-bounties", "pallet-bridge-grandpa", "pallet-bridge-messages", "pallet-bridge-parachains", "pallet-bridge-relayers", "pallet-broker", "pallet-child-bounties", "pallet-collator-selection", "pallet-collective", "pallet-collective-content", "pallet-contracts", "pallet-contracts-proc-macro", "pallet-contracts-uapi", "pallet-conviction-voting", "pallet-core-fellowship", "pallet-delegated-staking", "pallet-democracy", "pallet-dev-mode", "pallet-election-provider-multi-phase", "pallet-election-provider-support-benchmarking", "pallet-elections-phragmen", "pallet-fast-unstake", "pallet-glutton", "pallet-grandpa", "pallet-identity", "pallet-im-online", "pallet-indices", "pallet-insecure-randomness-collective-flip", "pallet-lottery", "pallet-membership", "pallet-message-queue", "pallet-migrations", "pallet-mixnet", "pallet-mmr", "pallet-multisig", "pallet-nft-fractionalization", "pallet-nfts", "pallet-nfts-runtime-api", "pallet-nis", "pallet-node-authorization", "pallet-nomination-pools", "pallet-nomination-pools-benchmarking", "pallet-nomination-pools-runtime-api", "pallet-offences", "pallet-offences-benchmarking", "pallet-paged-list", "pallet-parameters", "pallet-preimage", "pallet-proxy", "pallet-ranked-collective", "pallet-recovery", "pallet-referenda", "pallet-remark", "pallet-revive", "pallet-revive-proc-macro", "pallet-revive-uapi", "pallet-root-offences", "pallet-root-testing", "pallet-safe-mode", "pallet-salary", "pallet-scheduler", "pallet-scored-pool", "pallet-session", "pallet-session-benchmarking", "pallet-skip-feeless-payment", "pallet-society", "pallet-staking", "pallet-staking-reward-curve", "pallet-staking-reward-fn", "pallet-staking-runtime-api", "pallet-state-trie-migration", "pallet-statement", "pallet-sudo", "pallet-timestamp", "pallet-tips", "pallet-transaction-payment", "pallet-transaction-payment-rpc-runtime-api", "pallet-transaction-storage", "pallet-treasury", "pallet-tx-pause", "pallet-uniques", "pallet-utility", "pallet-verify-signature", "pallet-vesting", "pallet-whitelist", "pallet-xcm", "pallet-xcm-benchmarks", "pallet-xcm-bridge-hub", "pallet-xcm-bridge-hub-router", "parachains-common", "polkadot-core-primitives", "polkadot-parachain-primitives", "polkadot-primitives", "polkadot-runtime-common", "polkadot-runtime-metrics", "polkadot-runtime-parachains", "polkadot-sdk-frame", "sc-chain-spec-derive", "sc-tracing-proc-macro", "slot-range-helper", "snowbridge-beacon-primitives", "snowbridge-core", "snowbridge-ethereum", "snowbridge-outbound-queue-merkle-tree", "snowbridge-outbound-queue-runtime-api", "snowbridge-pallet-ethereum-client", "snowbridge-pallet-ethereum-client-fixtures", "snowbridge-pallet-inbound-queue", "snowbridge-pallet-inbound-queue-fixtures", "snowbridge-pallet-outbound-queue", "snowbridge-pallet-system", "snowbridge-router-primitives", "snowbridge-runtime-common", "snowbridge-system-runtime-api", "sp-api", "sp-api-proc-macro", "sp-application-crypto", "sp-arithmetic", "sp-authority-discovery", "sp-block-builder", "sp-consensus-aura", "sp-consensus-babe", "sp-consensus-beefy", "sp-consensus-grandpa", "sp-consensus-pow", "sp-consensus-slots", "sp-core", "sp-crypto-ec-utils", "sp-crypto-hashing", "sp-crypto-hashing-proc-macro", "sp-debug-derive", "sp-externalities", "sp-genesis-builder", "sp-inherents", "sp-io", "sp-keyring", "sp-keystore", "sp-metadata-ir", "sp-mixnet", "sp-mmr-primitives", "sp-npos-elections", "sp-offchain", "sp-runtime", "sp-runtime-interface", "sp-runtime-interface-proc-macro", "sp-session", "sp-staking", "sp-state-machine", "sp-statement-store", "sp-std", "sp-storage", "sp-timestamp", "sp-tracing", "sp-transaction-pool", "sp-transaction-storage-proof", "sp-trie", "sp-version", "sp-version-proc-macro", "sp-wasm-interface", "sp-weights", "staging-parachain-info", "staging-xcm", "staging-xcm-builder", "staging-xcm-executor", "substrate-bip39", "testnet-parachains-constants", "tracing-gum-proc-macro", "xcm-procedural", "xcm-runtime-apis"]
+runtime-full = ["assets-common", "binary-merkle-tree", "bp-header-chain", "bp-messages", "bp-parachains", "bp-polkadot", "bp-polkadot-core", "bp-relayers", "bp-runtime", "bp-test-utils", "bp-xcm-bridge-hub", "bp-xcm-bridge-hub-router", "bridge-hub-common", "bridge-runtime-common", "cumulus-pallet-aura-ext", "cumulus-pallet-dmp-queue", "cumulus-pallet-parachain-system", "cumulus-pallet-parachain-system-proc-macro", "cumulus-pallet-session-benchmarking", "cumulus-pallet-solo-to-para", "cumulus-pallet-weight-reclaim", "cumulus-pallet-xcm", "cumulus-pallet-xcmp-queue", "cumulus-ping", "cumulus-primitives-aura", "cumulus-primitives-core", "cumulus-primitives-parachain-inherent", "cumulus-primitives-proof-size-hostfunction", "cumulus-primitives-storage-weight-reclaim", "cumulus-primitives-timestamp", "cumulus-primitives-utility", "frame-benchmarking", "frame-benchmarking-pallet-pov", "frame-election-provider-solution-type", "frame-election-provider-support", "frame-executive", "frame-metadata-hash-extension", "frame-support", "frame-support-procedural", "frame-support-procedural-tools-derive", "frame-system", "frame-system-benchmarking", "frame-system-rpc-runtime-api", "frame-try-runtime", "pallet-alliance", "pallet-asset-conversion", "pallet-asset-conversion-ops", "pallet-asset-conversion-tx-payment", "pallet-asset-rate", "pallet-asset-tx-payment", "pallet-assets", "pallet-assets-freezer", "pallet-atomic-swap", "pallet-aura", "pallet-authority-discovery", "pallet-authorship", "pallet-babe", "pallet-bags-list", "pallet-balances", "pallet-beefy", "pallet-beefy-mmr", "pallet-bounties", "pallet-bridge-grandpa", "pallet-bridge-messages", "pallet-bridge-parachains", "pallet-bridge-relayers", "pallet-broker", "pallet-child-bounties", "pallet-collator-selection", "pallet-collective", "pallet-collective-content", "pallet-contracts", "pallet-contracts-proc-macro", "pallet-contracts-uapi", "pallet-conviction-voting", "pallet-core-fellowship", "pallet-delegated-staking", "pallet-democracy", "pallet-dev-mode", "pallet-election-provider-multi-phase", "pallet-election-provider-support-benchmarking", "pallet-elections-phragmen", "pallet-fast-unstake", "pallet-glutton", "pallet-grandpa", "pallet-identity", "pallet-im-online", "pallet-indices", "pallet-insecure-randomness-collective-flip", "pallet-lottery", "pallet-membership", "pallet-message-queue", "pallet-migrations", "pallet-mixnet", "pallet-mmr", "pallet-multisig", "pallet-nft-fractionalization", "pallet-nfts", "pallet-nfts-runtime-api", "pallet-nis", "pallet-node-authorization", "pallet-nomination-pools", "pallet-nomination-pools-benchmarking", "pallet-nomination-pools-runtime-api", "pallet-offences", "pallet-offences-benchmarking", "pallet-paged-list", "pallet-parameters", "pallet-preimage", "pallet-proxy", "pallet-ranked-collective", "pallet-recovery", "pallet-referenda", "pallet-remark", "pallet-revive", "pallet-revive-proc-macro", "pallet-revive-uapi", "pallet-root-offences", "pallet-root-testing", "pallet-safe-mode", "pallet-salary", "pallet-scheduler", "pallet-scored-pool", "pallet-session", "pallet-session-benchmarking", "pallet-skip-feeless-payment", "pallet-society", "pallet-staking", "pallet-staking-reward-curve", "pallet-staking-reward-fn", "pallet-staking-runtime-api", "pallet-state-trie-migration", "pallet-statement", "pallet-sudo", "pallet-timestamp", "pallet-tips", "pallet-transaction-payment", "pallet-transaction-payment-rpc-runtime-api", "pallet-transaction-storage", "pallet-treasury", "pallet-tx-pause", "pallet-uniques", "pallet-utility", "pallet-verify-signature", "pallet-vesting", "pallet-whitelist", "pallet-xcm", "pallet-xcm-benchmarks", "pallet-xcm-bridge-hub", "pallet-xcm-bridge-hub-router", "parachains-common", "polkadot-core-primitives", "polkadot-parachain-primitives", "polkadot-primitives", "polkadot-runtime-common", "polkadot-runtime-metrics", "polkadot-runtime-parachains", "polkadot-sdk-frame", "sc-chain-spec-derive", "sc-tracing-proc-macro", "slot-range-helper", "snowbridge-beacon-primitives", "snowbridge-core", "snowbridge-ethereum", "snowbridge-outbound-queue-merkle-tree", "snowbridge-outbound-queue-runtime-api", "snowbridge-pallet-ethereum-client", "snowbridge-pallet-ethereum-client-fixtures", "snowbridge-pallet-inbound-queue", "snowbridge-pallet-inbound-queue-fixtures", "snowbridge-pallet-outbound-queue", "snowbridge-pallet-system", "snowbridge-router-primitives", "snowbridge-runtime-common", "snowbridge-system-runtime-api", "sp-api", "sp-api-proc-macro", "sp-application-crypto", "sp-arithmetic", "sp-authority-discovery", "sp-block-builder", "sp-consensus-aura", "sp-consensus-babe", "sp-consensus-beefy", "sp-consensus-grandpa", "sp-consensus-pow", "sp-consensus-slots", "sp-core", "sp-crypto-ec-utils", "sp-crypto-hashing", "sp-crypto-hashing-proc-macro", "sp-debug-derive", "sp-externalities", "sp-genesis-builder", "sp-inherents", "sp-io", "sp-keyring", "sp-keystore", "sp-metadata-ir", "sp-mixnet", "sp-mmr-primitives", "sp-npos-elections", "sp-offchain", "sp-runtime", "sp-runtime-interface", "sp-runtime-interface-proc-macro", "sp-session", "sp-staking", "sp-state-machine", "sp-statement-store", "sp-std", "sp-storage", "sp-timestamp", "sp-tracing", "sp-transaction-pool", "sp-transaction-storage-proof", "sp-trie", "sp-version", "sp-version-proc-macro", "sp-wasm-interface", "sp-weights", "staging-parachain-info", "staging-xcm", "staging-xcm-builder", "staging-xcm-executor", "substrate-bip39", "substrate-wasm-builder", "testnet-parachains-constants", "tracing-gum-proc-macro", "xcm-procedural", "xcm-runtime-apis"]

The change add unexpected substrate-wasm-builder

jasl · 2025-01-09T01:18:13Z

I believe your original one is good, but I don't know why CI give you the false suggest.

@StackOverflowExcept1on Could you try don't change node = [...] and runtime-full = [...] just change the location of [dependencies.substrate-wasm-builder] ?

jasl · 2025-01-09T14:12:21Z

@bkchr Could you help to re-trigger CI?

@StackOverflowExcept1on I think you still need to apply @bkchr request

Just check for the available targets (I think we already have code for that) and then use the new target if available. If the new target is not available, print a warning to the build output.

Thank you for the work. I'm trying to migrate to Rust 2024 Edition when it's available.

StackOverflowExcept1on · 2025-01-09T14:20:45Z

@jasl I'm still working on this request. It would be nice to have the ability to run CI without pinging the parity team...

No. Just check for the available targets (I think we already have code for that) and then use the new target if available. If the new target is not available, print a warning to the build output.

jasl · 2025-01-09T14:26:32Z

@jasl I'm still working on this request. It would be nice to have the ability to run CI without pinging the parity team...

No. Just check for the available targets (I think we already have code for that) and then use the new target if available. If the new target is not available, print a warning to the build output.

This is a pain point. I guess it is about the cost.
When I fix CI fails, I usually use my local machine to replay failed CI checks, which would help to reduce attempts on GitHub Actions.

If possible, I would propose giving "verified" individual contributors an ability to trigger CI.

bkchr · 2025-01-09T15:43:18Z

These are some annoying security requirements. Which someone apparently turned on again..

jasl · 2025-01-09T15:50:42Z

@bkchr
So https://github.com/paritytech/polkadot-sdk/actions/runs/12687523704/job/35380981212?pr=7008 still gives falsy suggestions...
Do you know who can help this?

StackOverflowExcept1on · 2025-01-09T16:33:10Z

I should probably update prdoc as well: https://github.com/paritytech/polkadot-sdk/actions/runs/12687523719/job/35380940517
The only thing I don't know how to fix:

substrate-wasm-builder (substrate/utils/wasm-builder):
    Change stated in PR Doc: Minor
    Predicted semver change: Patch

prdoc/pr_7008.prdoc

feat(wasm-builder): add support for new wasm32v1-none target

78c5f4c

StackOverflowExcept1on requested a review from koute as a code owner December 27, 2024 12:45

fix typo

dcfbeb7

bkchr approved these changes Dec 27, 2024

View reviewed changes

bkchr added the T17-primitives Changes to primitives that are not covered by any other label. label Dec 27, 2024

trying to fix CI

03714a0

github-actions bot requested a review from bkchr December 27, 2024 19:24

Merge branch 'master' into wasm32v1-none

2410530

bkchr approved these changes Dec 30, 2024

View reviewed changes

prdoc/pr_7008.prdoc Show resolved Hide resolved

Update prdoc/pr_7008.prdoc

575d805

koute approved these changes Jan 2, 2025

View reviewed changes

Merge branch 'master' into wasm32v1-none

8fffe18

bkchr enabled auto-merge January 2, 2025 09:55

Merge branch 'master' into wasm32v1-none

ce0fb1d

Merge branch 'master' into wasm32v1-none

3d26ce9

git apply patch from CI

4c3b0ea

auto-merge was automatically disabled January 8, 2025 17:19
Head branch was pushed to by a user without write access

github-actions bot requested review from bkchr and koute January 8, 2025 17:19

bkchr approved these changes Jan 8, 2025

View reviewed changes

Revert "git apply patch from CI"

486be73

This reverts commit 4c3b0ea.

github-actions bot requested a review from bkchr January 8, 2025 21:06

just changle location of substrate-wasm-builder

21245bc

Merge branch 'master' into wasm32v1-none

d044efc

Fix umbrella script

1f34087

bkchr reviewed Jan 10, 2025

View reviewed changes

prdoc/pr_7008.prdoc Show resolved Hide resolved

bkchr and others added 2 commits January 10, 2025 12:39

Update prdoc/pr_7008.prdoc

8ae5e7b

add sp-consensus-beefy bump patch to prdoc

f154742

github-actions bot requested a review from bkchr January 10, 2025 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wasm-builder): add support for new `wasm32v1-none` target #7008

feat(wasm-builder): add support for new `wasm32v1-none` target #7008

StackOverflowExcept1on commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024

StackOverflowExcept1on commented Jan 2, 2025

jasl commented Jan 8, 2025

jasl commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025 •

edited

Loading

jasl commented Jan 8, 2025

bkchr commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

jasl commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

jasl commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

jasl commented Jan 8, 2025

bkchr commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

jasl commented Jan 9, 2025 •

edited

Loading

jasl commented Jan 9, 2025

jasl commented Jan 9, 2025

jasl commented Jan 9, 2025

StackOverflowExcept1on commented Jan 9, 2025 •

edited

Loading

jasl commented Jan 9, 2025

bkchr commented Jan 9, 2025

jasl commented Jan 9, 2025

StackOverflowExcept1on commented Jan 9, 2025

feat(wasm-builder): add support for new wasm32v1-none target #7008

Are you sure you want to change the base?

feat(wasm-builder): add support for new wasm32v1-none target #7008

Conversation

StackOverflowExcept1on commented Dec 27, 2024 • edited Loading

Description

Integration

Review Notes

github-actions bot commented Dec 27, 2024

StackOverflowExcept1on commented Jan 2, 2025

jasl commented Jan 8, 2025

jasl commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025 • edited Loading

jasl commented Jan 8, 2025

bkchr commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

jasl commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

jasl commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

jasl commented Jan 8, 2025

bkchr commented Jan 8, 2025

StackOverflowExcept1on commented Jan 8, 2025

jasl commented Jan 9, 2025 • edited Loading

jasl commented Jan 9, 2025

jasl commented Jan 9, 2025

jasl commented Jan 9, 2025

StackOverflowExcept1on commented Jan 9, 2025 • edited Loading

jasl commented Jan 9, 2025

bkchr commented Jan 9, 2025

jasl commented Jan 9, 2025

StackOverflowExcept1on commented Jan 9, 2025

feat(wasm-builder): add support for new `wasm32v1-none` target #7008

feat(wasm-builder): add support for new `wasm32v1-none` target #7008

StackOverflowExcept1on commented Dec 27, 2024 •

edited

Loading

StackOverflowExcept1on commented Jan 8, 2025 •

edited

Loading

jasl commented Jan 9, 2025 •

edited

Loading

StackOverflowExcept1on commented Jan 9, 2025 •

edited

Loading