Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for generics inderive-impl #5584

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Sep 4, 2024

As raised by @kianenigma in sam0x17/macro_magic#15, this PR adds the support for generics while using derive_impl.

This can then be used in conjunction with FliteFrameSystem being defined here as

+#[derive_impl(FliteFrameSystem<Configuration>)]
impl frame_system::Config for Runtime {
  type Block = Block;

  // .. Rest can be removed
}

@gupnik gupnik added the R0-silent Changes should not be mentioned in any release notes label Sep 4, 2024
@gupnik gupnik requested a review from a team as a code owner September 4, 2024 09:46
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! can we have a e2e-ish example in our repo as well?

Else, can you see if you can fix flite/runtime using this?

It should be fairly easy to update the dependencies to this PR's last commit, given that we use the umbrella crate there :)

@gupnik
Copy link
Contributor Author

gupnik commented Sep 6, 2024

Else, can you see if you can fix flite/runtime using this?

Created a PR with the fix in flite: kianenigma/flite#1

@franciscoaguirre
Copy link
Contributor

This is going to be insanely useful 🚀

@kianenigma
Copy link
Contributor

This is going to be insanely useful 🚀

wen XCMLite? :D

@gupnik gupnik enabled auto-merge September 18, 2024 06:04
@gupnik gupnik added this pull request to the merge queue Sep 18, 2024
Merged via the queue into master with commit 69e9665 Sep 18, 2024
196 of 207 checks passed
@gupnik gupnik deleted the gupnik/derive-impl-generics branch September 18, 2024 07:09
@franciscoaguirre
Copy link
Contributor

This is going to be insanely useful 🚀

wen XCMLite? :D

On it now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants