Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions coverage #5148

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Github actions coverage #5148

merged 10 commits into from
Sep 5, 2024

Conversation

AndWeHaveAPlan
Copy link
Contributor

@AndWeHaveAPlan AndWeHaveAPlan commented Jul 25, 2024

Jobs for coverage collections and upload to codecov for github PR's
Uses same test suit as test-linux-stable, splits tests into 5 parallel jobs, uploads to codecov, generates report comment and status checks (can be made required)

image image

Codecov behavior (required coverage, thresholds, comment info etc.) is highly customizable via .github/codecov.yaml (reference)

Unfortunately, some tests are excluded because with -C instrument-coverage they run very slowly, flaky, or fail (see nextest filter expression of test-linux-stable-coverage). So for now, this workflow is optional, and will only run for pr's with the GHA-coverage label

@AndWeHaveAPlan AndWeHaveAPlan added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. labels Jul 25, 2024
@AndWeHaveAPlan AndWeHaveAPlan added the GHA-coverage run coverage workflow for this pr label Sep 4, 2024
@AndWeHaveAPlan AndWeHaveAPlan marked this pull request as ready for review September 5, 2024 08:53
@AndWeHaveAPlan AndWeHaveAPlan requested review from a team as code owners September 5, 2024 08:53
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving rust changes similar to #2644

@AndWeHaveAPlan AndWeHaveAPlan added this pull request to the merge queue Sep 5, 2024
Merged via the queue into master with commit b9b34fb Sep 5, 2024
201 of 209 checks passed
@AndWeHaveAPlan AndWeHaveAPlan deleted the es/coverage branch September 5, 2024 16:26
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.46%. Comparing base (37b1544) to head (31de062).
Report is 582 commits behind head on master.

Current head 31de062 differs from pull request most recent head 3c09678

Please upload reports for the commit 3c09678 to get more accurate results.

Additional details and impacted files
Files with missing lines Coverage Δ
substrate/bin/node/runtime/src/lib.rs 10.58% <ø> (ø)
substrate/frame/babe/src/mock.rs 86.44% <ø> (ø)
substrate/frame/grandpa/src/mock.rs 80.92% <ø> (ø)

... and 2693 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a6813...3c09678. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GHA-coverage run coverage workflow for this pr R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants