Implement tr_serialize and tr_deserialize #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandsimon
force-pushed
the
sbr/serialize
branch
8 times, most recently
from
b8eb40e to
3905696
Compare
brandsimon
changed the title
brandsimon
force-pushed
the
sbr/serialize
branch
5 times, most recently
from
9c98521 to
5dc42e9
Compare
Superhepper
reviewed
Oct 25, 2023
Superhepper
reviewed
Oct 25, 2023
tss-esapi/tests/integration_tests/context_tests/general_esys_tr_tests.rs
Outdated
Show resolved
Hide resolved
brandsimon
force-pushed
the
sbr/serialize
branch
from
5dc42e9 to
48c1046
Compare
|
@Superhepper |
brandsimon
changed the title
brandsimon
force-pushed
the
sbr/serialize
branch
2 times, most recently
from
a3af865 to
3122e78
Compare
Superhepper
reviewed
Oct 29, 2023
brandsimon
force-pushed
the
sbr/serialize
branch
2 times, most recently
from
cacf52e to
ecb9624
Compare
|
@ionut-arm @Superhepper |
Superhepper
previously approved these changes
Nov 1, 2023
wiktor-k
previously approved these changes
Nov 1, 2023
tss-esapi/tests/integration_tests/context_tests/general_esys_tr_tests.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Brand <simon.brand@postadigitale.de>
brandsimon
force-pushed
the
sbr/serialize
branch
from
ecb9624 to
3386cb2
Compare
Superhepper
approved these changes
Nov 3, 2023
ionut-arm
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if the implementation with
buffer.len().try_into().map_errandstd::slice::from_raw_partsis the cleanest solution. Please let me know if you have ideas for cleaner solutions.Regarding the tests, the
new_handle = old_handle + 1, but I think checking the public part (which includes the public key) is the most relevant test for it.Edit:
The test with the new context is needed. Currently it works with the old context, but not with a new one.