Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition for UndefineSpaceSpecial #459

Merged

Conversation

nathanrossi
Copy link

Add a implementation for the UndefineSpaceSpecial function which is used to delete an NV index that has the TPMA_NV_POLICY_DELETE attribute set.

An example and test are included for this function, setting up the NV index and deleting it requires additional initialization of a policy digest as well as a policy session in order to perform the delete due to the policy requiring the NvUndefineSpaceSpecial command code defined.

Add a implementation for the UndefineSpaceSpecial function which is used
to delete an NV index that has the TPMA_NV_POLICY_DELETE attribute set.

An example and test are included for this function, setting up the NV
index and deleting it requires additional initialization of a policy
digest as well as a policy session in order to perform the delete due to
the policy requiring the NvUndefineSpaceSpecial command code defined.

Signed-off-by: Nathan Rossi <nathan.rossi@digi.com>
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not strictly my area of expertise but I've read the PR and it looks high-quality. Thanks for your time! 👍

/// the nv area that is to be removed.
///
/// # Example
/// ```rust
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A newline here would be nice :)

Copy link
Collaborator

@Superhepper Superhepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

@Superhepper Superhepper merged commit 514c21b into parallaxsecond:main Oct 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants