chore: trim ConfigureEvm trait #13807
Merged
+105
−386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez,
rakita and
gakonst
as code owners
klkvr
force-pushed
the
klkvr/remove-configure-evm-methods
branch
from
8d4f75c to
0740a14
Compare
klkvr
force-pushed
the
klkvr/remove-configure-evm-methods
branch
from
4592b22 to
eb8d8a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13800
This PR only keeps
evm_with_envandevm_with_env_and_inspectormethods onConfigureEvmtrait which are the only ones used.Default method implementations for those are removed to allow them to return types different from
revm::EvmeventuallyRethEvmBuilderis removed as well as it doesn't provide much simplification at this point