Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add OpEthApiBuilder and OpEthApiInner #13009

Merged
merged 15 commits into from
Dec 2, 2024
Merged

chore: add OpEthApiBuilder and OpEthApiInner #13009

merged 15 commits into from
Dec 2, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Nov 29, 2024 •
edited
Loading

Adds:

  • OpAddOnsBuilder
  • OpEthApiBuilder
  • OpEthApiInner

@joshieDo joshieDo added A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Nov 29, 2024
@joshieDo joshieDo changed the title feat: add storage_proofs_only to RollupArgs feat: add storage_proof_only argument to RollupArgs Nov 29, 2024
mattsse
mattsse requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions, directionally lgtm

crates/optimism/rpc/src/eth/mod.rs Outdated Show resolved Hide resolved
crates/optimism/rpc/src/eth/mod.rs Outdated Show resolved Hide resolved
@joshieDo joshieDo mentioned this pull request Nov 29, 2024
Closed
@joshieDo joshieDo requested a review from mattsse November 29, 2024 15:43
@joshieDo joshieDo marked this pull request as ready for review November 29, 2024 15:43
mattsse
mattsse requested changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic style nits and opinionated suggestions

crates/optimism/node/src/node.rs Outdated Show resolved Hide resolved
crates/optimism/rpc/src/eth/mod.rs Outdated Show resolved Hide resolved
crates/optimism/rpc/src/eth/mod.rs Outdated Show resolved Hide resolved
crates/optimism/node/tests/it/builder.rs Outdated Show resolved Hide resolved
crates/optimism/node/src/node.rs Outdated Show resolved Hide resolved
crates/optimism/node/src/node.rs Outdated Show resolved Hide resolved
crates/optimism/rpc/src/eth/mod.rs Outdated Show resolved Hide resolved
@joshieDo joshieDo changed the title feat: add storage_proof_only argument to RollupArgs chore: add OpEthApiBuilder and OpEthApiInner Dec 2, 2024
@mattsse mattsse added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 6789ff4 Dec 2, 2024
42 checks passed
@mattsse mattsse deleted the joshie/opproof branch December 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse