Skip to content

Commit

Permalink
feat: bound NetworkPrimitives types by proper traits (#13196)
Browse files Browse the repository at this point in the history
  • Loading branch information
Rjected authored Dec 9, 2024
1 parent f7a3476 commit d68d7c8
Showing 1 changed file with 4 additions and 39 deletions.
43 changes: 4 additions & 39 deletions crates/net/eth-wire-types/src/primitives.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Abstraction over primitive types in network messages.
use alloy_rlp::{Decodable, Encodable};
use reth_primitives_traits::{Block, BlockHeader, SignedTransaction};
use reth_primitives_traits::{Block, BlockBody, BlockHeader, SignedTransaction};
use std::fmt::Debug;

/// Abstraction over primitive types which might appear in network messages. See
Expand All @@ -10,56 +10,21 @@ pub trait NetworkPrimitives:
Send + Sync + Unpin + Clone + Debug + PartialEq + Eq + 'static
{
/// The block header type.
type BlockHeader: BlockHeader
+ Encodable
+ Decodable
+ Send
+ Sync
+ Unpin
+ Clone
+ Debug
+ PartialEq
+ Eq
+ 'static;
type BlockHeader: BlockHeader + 'static;

/// The block body type.
type BlockBody: Encodable
+ Decodable
+ Send
+ Sync
+ Unpin
+ Clone
+ Debug
+ PartialEq
+ Eq
+ 'static;
type BlockBody: BlockBody + 'static;

/// Full block type.
type Block: Block<Header = Self::BlockHeader, Body = Self::BlockBody>
+ Encodable
+ Decodable
+ Send
+ Sync
+ Unpin
+ Clone
+ Debug
+ PartialEq
+ Eq
+ 'static;

/// The transaction type which peers announce in `Transactions` messages. It is different from
/// `PooledTransactions` to account for Ethereum case where EIP-4844 transactions are not being
/// announced and can only be explicitly requested from peers.
type BroadcastedTransaction: Encodable
+ Decodable
+ Send
+ Sync
+ Unpin
+ Clone
+ Debug
+ PartialEq
+ Eq
+ 'static;
type BroadcastedTransaction: SignedTransaction + 'static;

/// The transaction type which peers return in `PooledTransactions` messages.
type PooledTransaction: SignedTransaction + TryFrom<Self::BroadcastedTransaction> + 'static;
Expand Down

0 comments on commit d68d7c8

Please sign in to comment.