nfpm(bugfix): handle package targets w/ output_path #21806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A package target with an output_path puts the packaged file relative to the build_root instead of relative to the BUILD file. So, we need to explicitly check for both the file_path (relative to BUILD file) and the value (which might be relative to the build_root) instead of just the file_path.
Debugging missing files is very difficult because the sandbox cannot be inspected until pants creates a process sandbox. The src is missing error happens before running nfpm, however, so there is no sandbox to "preserve on_failure". So, the error message also includes the list of sandbox files now.
|
I put this in the 2.23.x milestone because the I also skipped release notes. |
cognifloyd
added
the
release-notes:not-required
tdyas
approved these changes
Jan 2, 2025
cognifloyd
added a commit
that referenced
this pull request
Jan 2, 2025
…21806) (#21809) A package target with an output_path puts the packaged file relative to the build_root instead of relative to the BUILD file. So, we need to explicitly check for both the file_path (relative to BUILD file) and the value (which might be relative to the build_root) instead of just the file_path. In debugging this, I ended up copying the plugin code into a separate repo so I could figure out what was going wrong. It would have been easier to debug if the sandbox contents were listed in the error message that claims the src file was missing. So, this also expands the error messages so future issues can be identified (hopefully) more simply. Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>
cognifloyd
added a commit
that referenced
this pull request
Jan 2, 2025
…21806) (#21808) A package target with an output_path puts the packaged file relative to the build_root instead of relative to the BUILD file. So, we need to explicitly check for both the file_path (relative to BUILD file) and the value (which might be relative to the build_root) instead of just the file_path. In debugging this, I ended up copying the plugin code into a separate repo so I could figure out what was going wrong. It would have been easier to debug if the sandbox contents were listed in the error message that claims the src file was missing. So, this also expands the error messages so future issues can be identified (hopefully) more simply. Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A package target with an output_path puts the packaged file relative to the build_root instead of relative to the BUILD file. So, we need to explicitly check for both the file_path (relative to BUILD file) and the value (which might be relative to the build_root) instead of just the file_path.
In debugging this, I ended up copying the plugin code into a separate repo so I could figure out what was going wrong. It would have been easier to debug if the sandbox contents were listed in the error message that claims the src file was missing. So, this also expands the error messages so future issues can be identified (hopefully) more simply.