Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to generate ruff report #21783

Merged
merged 5 commits into from
Dec 23, 2024

Conversation

erjac77
Copy link
Contributor

@erjac77 erjac77 commented Dec 19, 2024

This PR adds support for generating Ruff report using the --output-file flag.

Replaces #19441
Closes #21782


Probably the first PR written using the dev container!! I have some small improvements to the startup scripts that I will submit via another PR.

Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

This PR looks good, except for tweaking the changelog.

Relatedly (but not blocking this PR), do you know if ruff format supports --output-file in a useful way?

docs/notes/2.25.x.md Outdated Show resolved Hide resolved
@erjac77
Copy link
Contributor Author

erjac77 commented Dec 23, 2024

Relatedly (but not blocking this PR), do you know if ruff format supports --output-file in a useful way?

According to the documentation, the --output-file option is only available for the linter.

Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great

And thanks for the docs link 👍

@huonw huonw merged commit 6c5df42 into pantsbuild:main Dec 23, 2024
24 checks passed
@huonw huonw mentioned this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to generate Ruff output file
2 participants