only emit a mkdir into remote execution wrapper for non-empty paths
#21753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
added
category:bugfix
huonw
approved these changes
Dec 12, 2024
The wrapper script is already written by a function. Probably makes sense to create a directory and just literally run that script in the directory? |
|
Added a basic test of the wrapper script, which executes the wrapper script in a temporary directory and verified that the cache directory and sandbox symlink are created. |
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.24.xSuccessfully opened #21760. Thanks again for your contributions! |
tdyas
added a commit
that referenced
this pull request
Dec 14, 2024
… (Cherry-pick of #21753) (#21760) As reported in #21747, the remote execution wrapper used to set up append-only cache directories was trying to create an empty path as a directory. This occurred because `Path::parent` returns an empty string (`Some("")`) if the path was not absolute (i.e., the "root" was not `""` and not `"/"`). Solution: Check for that condition and do not emit the `mkdir` in that case. Co-authored-by: Tom Dyas <tom@shoalsoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #21747, the remote execution wrapper used to set up append-only cache directories was trying to create an empty path as a directory. This occurred because
Path::parentreturns an empty string (Some("")) if the path was not absolute (i.e., the "root" was not""and not"/").Solution: Check for that condition and do not emit the
mkdirin that case.