-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated pkg_resources #52
Open
mister-scott
wants to merge
11
commits into
owodunni:master
Choose a base branch
from
mister-scott:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg_resources has been deprecated. Making use of drop-in replacement importlib.resources
Both of the following resources state that the Variance of Operator by Part (aka Technician by Part) is equal to (MS_operator_by_part - MS_equipment) / N_replications. Previous code indicated that value was to be divided by N_parts.
Checked the maths against online resources https://www.spcforexcel.com/knowledge/measurement-systems-analysis/anova-gage-rr-part-1 and https://sixsigmastudyguide.com/repeatability-and-reproducibility-rr/. Found an with calculation of GRR wherein Operator by Part was being included.
Validated the data processing against a GageR&R study from Minitab, added summary tables for the Variance Components and Gage Evaluation, and made some simple functions to get 'so-what' data like GRR Variance and Total Variance faster. Also added maths to handle removal of interaction terms with P-values greater than some provided amount (default 1 to effectively disable feature), and added process tolerance input to calculate the percent tolerance (%Study Variance / %Tolerance).
Enable use of hover-data feature for boxplots generated for reports.
Specified UTF-8 as encoding method for importlib calls.
Enabled ability to set range for box plots for establishing unified datasets.
A list of horizontal lines may be passed into the createPartsBoxPlot and createOperatorsBoxPlot functions to generate visible lines for use as pass/fail criteria lines, etc.
Simpler data parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources has been deprecated. Making use of drop-in replacement importlib.resources.