Skip to content

Commit

Permalink
ci: Pin Python, Fedora and Ubuntu runner versions.
Browse files Browse the repository at this point in the history
We initially thought always using the latest releases would be more
maintainable because we didn't have to bump versions manually.  It turns
out that it's the opposite, CI suddenly starts to fail on versions where
it used to pass.

To avoid ever changing tools in our CI due to newer releases of
Python/Fedora/Ubuntu.  We can always bump versions manually.

Fixes: 5ee07b3 ("ci: Change all GitHub CI jobs to use ubuntu-latest.")
Fixes: 60a53ab ("ci: Add automation for building the containers")
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Acked-by: Ales Musil <amusil@redhat.com>
Acked-by: Mark Michelson <mmichels@redhat.com>
(cherry picked from commit 278e0d3)
  • Loading branch information
dceara committed Nov 17, 2023
1 parent ffa0f6f commit 5f695fb
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/containers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ env:

jobs:
container:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
distro: [ fedora, ubuntu ]
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ovn-fake-multinode-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ concurrency:
jobs:
build:
name: Build ovn-fake-multinode image
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
cfg:
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
path: /tmp/_output/ovn_${{ matrix.cfg.branch }}_image.tar

multinode-tests:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
timeout-minutes: 15
needs: [build]
strategy:
Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:
- name: set up python
uses: actions/setup-python@v4
with:
python-version: '3.x'
python-version: '3.11'

- name: Check out ovn
uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ovn-kubernetes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ env:
jobs:
build:
name: Build
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Enable Docker experimental features
run: |
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
e2e:
name: e2e
if: github.event_name != 'schedule'
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
timeout-minutes: 220
strategy:
fail-fast: false
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
SANITIZERS: ${{ matrix.cfg.sanitizers }}

name: linux ${{ join(matrix.cfg.*, ' ') }}
runs-on: ubuntu-latest
runs-on: ubuntu-22.04

strategy:
fail-fast: false
Expand Down Expand Up @@ -145,7 +145,7 @@ jobs:
- name: set up python
uses: actions/setup-python@v4
with:
python-version: '3.x'
python-version: '3.11'
- name: prepare
run: ./.ci/osx-prepare.sh
- name: build
Expand All @@ -159,8 +159,8 @@ jobs:

build-linux-rpm:
name: linux rpm fedora
runs-on: ubuntu-latest
container: fedora:latest
runs-on: ubuntu-22.04
container: fedora:38
timeout-minutes: 30

strategy:
Expand Down
2 changes: 1 addition & 1 deletion utilities/containers/fedora/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/fedora/fedora:latest
FROM quay.io/fedora/fedora:38

ARG CONTAINERS_PATH

Expand Down
2 changes: 1 addition & 1 deletion utilities/containers/ubuntu/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.hub.docker.com/library/ubuntu:latest
FROM registry.hub.docker.com/library/ubuntu:22.04

ARG CONTAINERS_PATH

Expand Down

0 comments on commit 5f695fb

Please sign in to comment.