Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do.sh: Add ability to run ovn-heater on Ubuntu #190

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

mkalcok
Copy link
Contributor

@mkalcok mkalcok commented Dec 12, 2023

Please review commit-by-commit.

This is a follow-up change after ovn-fake-multinode added support for ubuntu-baed builds (ovn-org/ovn-fake-multinode#85)

@mkalcok mkalcok changed the title Ubuntu image do.sh: Add ability to run ovn-heater on Ubuntu Dec 12, 2023
This is a follow-up change after ovn-fake-multinode added option
to be built on Ubuntu images [0]. It allows ovn-heater to optionally
run on top of ubuntu-based ovn-fake-multinode.

[0] ovn-org/ovn-fake-multinode#85

Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
@mkalcok mkalcok marked this pull request as draft December 12, 2023 23:05
With the addition of `./do.sh refresh-tester` it is no longer
required to run `install` on changes to `ovn-tester`

Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
@mkalcok
Copy link
Contributor Author

mkalcok commented Dec 15, 2023

This change should clear out the failing CI: ovn-org/ovn-fake-multinode#87

@dceara
Copy link
Collaborator

dceara commented Dec 15, 2023

This change should clear out the failing CI: ovn-org/ovn-fake-multinode#87

Ack, I triggered a retry of the CI after merging the ovn-fake-multinode PR.

@mkalcok mkalcok marked this pull request as ready for review December 15, 2023 21:02
Copy link
Collaborator

@dceara dceara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned about using ubuntu:rolling (latest release, not latest LTS IIUC) in CI. Let's allow it for now, we can always go to ubuntu:latest (or a fixed version) if needed.

@dceara dceara merged commit afb5c54 into ovn-org:main Dec 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants