Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat unspecified max as 1 #349

Closed
wants to merge 1 commit into from
Closed

treat unspecified max as 1 #349

wants to merge 1 commit into from

Conversation

blacob
Copy link

@blacob blacob commented Jan 24, 2023

This rectifies an incongruence between the model generation and the validity checking.
If you present a schema a scalar type with min = 0, and without a max, then the validator expects it to be a pointer, not an array.

@blacob
Copy link
Author

blacob commented Jan 24, 2023

#348

@coveralls
Copy link

coveralls commented Jan 24, 2023

Pull Request Test Coverage Report for Build 3999035992

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.015%

Totals Coverage Status
Change from base Build 3912893139: 0.0%
Covered Lines: 5047
Relevant Lines: 6728

💛 - Coveralls

Signed-off-by: Jacob Bland <jbland@crusoeenergy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants