Model-based Monitor API #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 936990382
💛 - Coveralls |
halfcrazy
reviewed
Jun 14, 2021
halfcrazy
reviewed
Jun 14, 2021
halfcrazy
reviewed
Jun 14, 2021
|
Thanks for the comments @halfcrazy. All addressed. |
amorenoz
reviewed
Jun 14, 2021
amorenoz
reviewed
Jun 14, 2021
Specifying a custom Monitor is harder now we have models as it requires
the user to know the names of the Table and Fields they are interested
in. We already have this data in the model.
This commit changes the API to make it easier.
For example:
```
err = ovs.Monitor("play_with_ovs",
ovs.NewTableMonitor(&OpenvSwitch{}),
ovs.NewTableMonitor(&Bridge{}),
)
```
You can optionally provide pointers to the fields in a model to monitor
only those columns.
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
amorenoz
reviewed
Jun 16, 2021
| columns = append(columns, column) | ||
| } | ||
| } else { | ||
| for c := range info.table.Columns { |
There was a problem hiding this comment.
nit: I think empty columns stand for "all" columns
| @@ -254,18 +257,11 @@ func (ovs OvsdbClient) Transact(operation ...ovsdb.Operation) ([]ovsdb.Operation | |||
|
|
|||
| // MonitorAll is a convenience method to monitor every table/column | |||
| func (ovs OvsdbClient) MonitorAll(jsonContext interface{}) error { | |||
There was a problem hiding this comment.
I'm wondering if MonitorAll could just be replaced by Monitor with no options...
There was a problem hiding this comment.
It could. And I think we can address that in a follow up that deprecates MonitorAll entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying a custom Monitor is harder now we have models as it requires
the user to know the names of the Table and Fields they are interested
in. We already have this data in the model.
This commit changes the API to make it easier.
For example:
You can optionally provide pointers to the fields in a model to monitor
only those columns.
Signed-off-by: Dave Tucker dave@dtucker.co.uk