Fixup regexes for version extraction #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex relies on finding the package in the APT Packages file and use the following line as the version line.
This works for
packages.ros.org
but fails on thesnapshots.ros.org
repository. (the following line isPriority: extra
)This PR modifies the regex to capture all the lines until the next empty line (all the package information) and extract the version number from the multiline test block captured.
To do so I modified the version pattern to expect
Version:
at the beginning of the line, and the package pattern to capture until the next empty line (\n\n
)