Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing Public Key and Incorrect Run Variable #34

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

josiahls
Copy link

First: Fixed is related to: #32 . For me the docker file would fail to install due to a missing key.

Second: Fixed run_container.bash.
Define DISPLAY_PARAMS:

    DISPLAY_PARAMS=" -v /tmp/.X11-unix:/tmp/.X11-unix -e DISPLAY=unix$DISPLAY"
  else
    echo nvidia-docker-plugin not responding on http://localhost:3476/docker/cli
    echo please install nvidia-docker-plugin
    echo https://github.com/NVIDIA/nvidia-docker/wiki/Installation
    exit -1
  fi
else
  DOCKER_GPU_PARAMS=""
  DISPLAY_PARAMS=""

But in the run section:

docker run --rm --name ${CONTAINER} \
  -e XAUTHORITY=/tmp/.docker.xauth \
  -e ROS_IP=${IP} \
  -e ROS_MASTER_URI=http://${IP}:11311 \
  --ip ${IP} \
  --net ${NETWORK} \
  -v "/etc/localtime:/etc/localtime:ro" \
  -v "/tmp/.docker.xauth:/tmp/.docker.xauth" \
  -v /dev/log:/dev/log \
  ${DOCKER_EXTRA_ARGS} \
  ${DOCKER_GPU_PARAMS} \
  ${DOCKER_DISPLAY_PARAMS} \
  ${IMAGE_NAME} \
  ${COMMAND}

Where is DISPLAY_PARAMS? I think it was meant to be DOCKER_DISPLAY_PARAMS?
My solution is add DISPLAY_PARAMS as an arguement.

josiah and others added 9 commits January 25, 2020 18:12
- Installation error
- Fixed display run variable
- Installation error
- Fixed display run variable
- Installation error
- Fixed display run variable
- Installation error
- Fixed display run variable
- Installation error
- Fixed display run variable
- Installation error
- Fixed display run variable
- Installation error
- Fixed display run variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant