-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTheoryTools: Use Zenodo data as artifact #4423
base: master
Are you sure you want to change the base?
FTheoryTools: Use Zenodo data as artifact #4423
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4423 +/- ##
==========================================
+ Coverage 84.34% 84.36% +0.02%
==========================================
Files 663 663
Lines 87788 87804 +16
==========================================
+ Hits 74042 74075 +33
+ Misses 13746 13729 -17
|
4ed293e
to
f718b36
Compare
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
@benlorenz can you check whether the new job step I added ( |
Yes that was what I had in mind but I see a small issue, that this will still be run in the default group when the tests are run locally without a testset. I will do a small refactoring of these subsets and push another change in a few minutes. |
A note on the serialization performance (repeating some of what I said during triage): I got the following for pure JSON parsing of the data:
@HereAround what are the timings on your computer? I hope that means we have indeed a chance to get the performance for loading these -- I'd be hoping for something below a minute. |
ping @antonydellavecchia |
I got the following: julia> @time JSON.parsefile("1511-03209.mrdi");
8.901444 seconds (77.98 M allocations: 3.434 GiB, 65.55% gc time, 0.16% compilation time)
julia> @time JSON.parsefile("1511-03209-resolved.mrdi");
65.112687 seconds (188.39 M allocations: 9.041 GiB, 88.51% gc time) |
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
I am generally speaking happy with this PR - ready for review. |
Thank you for your help @benlorenz and @aaruni96 ! |
The tar ball provided at https://zenodo.org/records/14611045 (version 2) can be downloaded. It contains two .mrdi files, which are the OSCAR serialization of two F-theory models. Creating these two models by loading in the .mrdi files takes about 5 to 10 minutes, each. Computing these models from scratch takes probably half an hour/3-4 hours, respectively. A stark improvement, that we must use.
@benlorenz The tar ball at zenodo is about 400MB in size. I would love to add a test for this artifact/creating the model. However, it seems to me, that this would burn too many resources. Any idea/suggestion?
cc @emikelsons @apturner