🌱 add vendor dir to .gitignore #1618
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
.gitignore
Outdated
| @@ -25,6 +25,7 @@ catalogd.yaml | |||
|
|
|||
| # Kubernetes Generated files - skip generated files, except for vendored files | |||
|
|
|||
| vendor/ | |||
| !vendor/**/zz_generated.* | |||
There was a problem hiding this comment.
Y'all reckon we need to keep !vendor/**/zz_generated.*? Won't it be generated anyway?
There was a problem hiding this comment.
We can test it out to see if I do not know this one.
I will defer this to others
There was a problem hiding this comment.
I don't think we need to keep !vendor/**/zz_generated.*. Looks like something that was cargo-culted from somewhere else.
There was a problem hiding this comment.
I do not see why we would as well.
So, if we have not an historical context here
/lgtm
/approve
There was a problem hiding this comment.
Anyway, seems reasonable as well to ping @tmshort to ensure that we have no historical context for that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1618 +/- ##
=======================================
Coverage 66.68% 66.69%
=======================================
Files 57 57
Lines 4584 4588 +4
=======================================
+ Hits 3057 3060 +3
- Misses 1302 1303 +1
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
gitignore/fixup
branch
from
90bda11 to
26db391
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Description
Adds
vendordir to .gitignore to avoid adding them by mistakeReviewer Checklist