Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upgrade Golang from 1.22 to 1.23 #1608

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

camilamacedo86
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner January 14, 2025 06:34
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b3b7df4
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67868388e021bc000821d32f
😎 Deploy Preview https://deploy-preview-1608--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (a67d023) to head (b3b7df4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
- Coverage   66.81%   66.68%   -0.14%     
==========================================
  Files          57       57              
  Lines        4584     4584              
==========================================
- Hits         3063     3057       -6     
- Misses       1298     1302       +4     
- Partials      223      225       +2     
Flag Coverage Δ
e2e 52.72% <ø> (-0.18%) ⬇️
unit 53.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Show resolved Hide resolved
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add the toolchain as well, that way we can track the latest z-stream without forcing downstream users to upgrade

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva enabled auto-merge January 14, 2025 15:33
@perdasilva perdasilva disabled auto-merge January 14, 2025 15:45
@perdasilva perdasilva enabled auto-merge January 14, 2025 15:45
@perdasilva perdasilva added this pull request to the merge queue Jan 14, 2025
Merged via the queue into operator-framework:main with commit da28803 Jan 14, 2025
21 of 23 checks passed
@camilamacedo86 camilamacedo86 deleted the golang-bump branch January 15, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants