🌱 e2e: add tests to validate metrics endpoint #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camilamacedo86
force-pushed
the
add-test-krp
branch
2 times, most recently
from
64626ee to
cdbef1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1522 +/- ##
=======================================
Coverage 74.68% 74.68%
=======================================
Files 42 42
Lines 3271 3271
=======================================
Hits 2443 2443
Misses 652 652
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
camilamacedo86
requested review from
joelanford,
perdasilva,
tmshort and
grokspawn
tmshort
reviewed
Dec 13, 2024
tmshort
reviewed
Dec 13, 2024
tmshort
reviewed
Dec 13, 2024
camilamacedo86
force-pushed
the
add-test-krp
branch
from
cdbef1b to
004d509
Compare
camilamacedo86
force-pushed
the
add-test-krp
branch
from
004d509 to
095294d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the RFC https://docs.google.com/document/d/1hYOtHWcfoX_zWvy2YeolQBGuDgmP72vXMlrj9q9kPBQ/edit?tab=t.0 we would like to add the tests before get merge the PR:#1475 just to ensure that the metrics work at the same way before and after the changes.
Motivation: #1509