Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Do not use a fixed namespace for metrics tests #506

Closed
wants to merge 1 commit into from
Closed

🐛 Do not use a fixed namespace for metrics tests #506

wants to merge 1 commit into from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jan 9, 2025

Follow op-con's lead on specifying a metrics address

@tmshort
Do not use a fixed namespace for metrics tests
a075f81 
Follow op-con's lead on specifying a metrics address

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort tmshort requested a review from a team as a code owner January 9, 2025 18:48
camilamacedo86
camilamacedo86 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Jan 9, 2025 •
edited
Loading

/hold

We might want do directly in the monorepo this one.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@tmshort tmshort marked this pull request as draft January 9, 2025 19:07
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Jan 9, 2025

Converting to draft, and we'll close once we get this fix into op-con

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.20%. Comparing base (efcba0d) to head (a075f81).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   37.20%   37.20%           
=======================================
  Files          15       15           
  Lines        1258     1258           
=======================================
  Hits          468      468           
  Misses        740      740           
  Partials       50       50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Jan 9, 2025 •
edited
Loading

@tmshort

Closing this one in favor of: operator-framework/operator-controller#1561

THX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

Assignees

@camilamacedo86 camilamacedo86

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmshort @camilamacedo86