Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 feat: add support for Podman as a container runtime #464

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

camilamacedo86
Copy link
Contributor

Since docker requires a license in some scenarios, we might have contributors who prefer to use Podman. This commit introduces the changes necessary to support both.

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner November 18, 2024 09:51
@camilamacedo86 camilamacedo86 changed the title ✨ feat: add support for Podman as a container runtime (Blcoked by https://github.com/operator-framework/catalogd/pull/462 ):sparkles: feat: add support for Podman as a container runtime Nov 18, 2024
@camilamacedo86 camilamacedo86 changed the title (Blcoked by https://github.com/operator-framework/catalogd/pull/462 ):sparkles: feat: add support for Podman as a container runtime (Blocked by #462 ):sparkles: feat: add support for Podman as a container runtime Nov 18, 2024
@camilamacedo86 camilamacedo86 changed the title (Blocked by #462 ):sparkles: feat: add support for Podman as a container runtime ✨ (Blocked by #462 ) feat: add support for Podman as a container runtime Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.23%. Comparing base (55689e8) to head (b1c5480).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files          15       15           
  Lines        1224     1224           
=======================================
  Hits          468      468           
  Misses        706      706           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camilamacedo86 camilamacedo86 changed the title ✨ (Blocked by #462 ) feat: add support for Podman as a container runtime :🌱: (Blocked by #462 ) feat: add support for Podman as a container runtime Nov 18, 2024
@camilamacedo86 camilamacedo86 changed the title :🌱: (Blocked by #462 ) feat: add support for Podman as a container runtime 🌱 (Blocked by #462 ) feat: add support for Podman as a container runtime Nov 18, 2024
@camilamacedo86 camilamacedo86 changed the title 🌱 (Blocked by #462 ) feat: add support for Podman as a container runtime 🌱 (Blocked by #462) feat: add support for Podman as a container runtime Nov 18, 2024
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I personally just have a symlink from docker to podman in path, but we already have CONTAINER_RUNTIME in Makefile in operator-controller and I'm up for consistency.

Let's resolve the blocker #462 and go ahead with this one.

@joelanford
Copy link
Member

If you are looking for a docker-based system on MacOS, I've been using colima successfully for quite awhile. It does not have the same license problems as the official Docker Desktop application and was more stable for me when I was trying to decide between podman desktop and colima.

I think it is fine to align this repo with operator-controller, but just be forewarned: the stance in operator-controller is that we do not and likely will not have CI setup for multiple container runtimes. Right now, we use docker officially, and podman is best-effort.

Since docker requires a license in some scenarios, we might have contributors who prefer to use Podman. This commit introduces the changes necessary to support both.
@camilamacedo86 camilamacedo86 changed the title 🌱 (Blocked by #462) feat: add support for Podman as a container runtime 🌱 feat: add support for Podman as a container runtime Nov 18, 2024
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating it. Looks good to me.

@camilamacedo86 camilamacedo86 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into operator-framework:main with commit 4dd7d59 Nov 18, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants