Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 doc: add steps to build and deploy locally to contributing guide #463

Conversation

camilamacedo86
Copy link
Contributor

  • Updated the Contributing guide with detailed instructions for building
    and deploying the project locally.
  • Steps include creating a local kind cluster, building the container,
    and loading it into the cluster.

This addition helps contributors set up their local environment efficiently.

- Updated the Contributing guide with detailed instructions for building
  and deploying the project locally.
- Steps include creating a local kind cluster, building the container,
  and loading it into the cluster.

This addition helps contributors set up their local environment efficiently.
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner November 18, 2024 09:38
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.23%. Comparing base (dd64145) to head (d5094b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files          15       15           
  Lines        1224     1224           
=======================================
  Hits          468      468           
  Misses        706      706           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +43 to +59
1. Create the cluster:

```sh
kind create cluster -n catalogd
```

2. Build your changes:

```sh
make build-container
```

3. Load the image locally and Deploy to Kind

```sh
make kind-load deploy
```
Copy link
Member

@m1kola m1kola Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last week I had to fix similar steps in operator-controller here. And I wondered why we have all this instead of just make run which does everything mentioned here.

Copy link
Contributor Author

@camilamacedo86 camilamacedo86 Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @m1kola

Thank you for your input
Regards:

I had to fix similar steps in operator-controller here.

You fixed a typo issue. It was missing the -n
I think we can agree that is not a good argumentation against it.

And I wondered why we have all this instead of just make run which does everything mentioned here.

  1. Avoid reliance on bingo's kind
    I want to use my own local kind installation, not a version tied to bingo (e.g., /Users/camilam/go/bin/kind-v0.24.0). Contributors should have flexibility without unnecessary dependencies. We must start thinking that people have their local envs and want to take advantage of staff.

  2. Improve clarity
    Contributors should quickly understand what each command does. Clear, concise documentation prevents wasted time.

  3. Enhance efficiency
    Running local tests for small contributions should be straightforward, not a time-consuming process.

Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a question about using multiple steps in docs vs single make run in both catalogd and operator-controller contributor docs.

@camilamacedo86 camilamacedo86 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into operator-framework:main with commit e3c877c Nov 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants