✨ updating demo to work with cert-manager, README with new demo #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 37.83% 37.83%
=======================================
Files 15 15
Lines 1208 1208
=======================================
Hits 457 457
Misses 701 701
Partials 50 50 ☔ View full report in Codecov by Sentry. |
tmshort
reviewed
Oct 21, 2024
grokspawn
force-pushed
the
demo-ca-cert-fix
branch
from
ca90c12 to
e88fc3a
Compare
grokspawn
force-pushed
the
demo-ca-cert-fix
branch
from
2ff528e to
d8dc9e7
Compare
In addition, there are some new waits introduced to give some more signal around some (very) intermittent install failures from the install script. This script now completely eschews installation via locally-defined resources and relies entirely on the latest release's scripts/manifests to install on the local cluster, so that we have fewer scripts to maintain. Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
joelanford
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demo was not updated to work with the cert-manager changes made earlier.
In addition, there are some new waits introduced to give some more signal around some (very) intermittent install failures from the install script.
This script now completely eschews installation via locally-defined resources and relies entirely on the latest release's scripts/manifests to install on the local cluster, so that we have fewer scripts to maintain.