Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adding Availability enum to catalog spec #421

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions api/core/v1alpha1/clustercatalog_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,17 @@ const (
// Serving reasons
ReasonAvailable = "Available"
ReasonUnavailable = "Unavailable"
ReasonDisabled = "Disabled"

// Progressing reasons
ReasonSucceeded = "Succeeded"
ReasonRetrying = "Retrying"
ReasonBlocked = "Blocked"

MetadataNameLabel = "olm.operatorframework.io/metadata.name"

AvailabilityEnabled = "Enabled"
AvailabilityDisabled = "Disabled"
)

//+kubebuilder:object:root=true
Expand Down Expand Up @@ -92,6 +96,20 @@ type ClusterCatalogSpec struct {
// +kubebuilder:default:=0
// +optional
Priority int32 `json:"priority"`

// Availability is an optional field that allows users to define whether the ClusterCatalog is utilized by the operator-controller.
//
// Allowed values are : ["Enabled", "Disabled"].
// If set to "Enabled", the catalog will be used for updates, serving contents, and package installations.
//
// If set to "Disabled", catalogd will stop serving the catalog and the cached data will be removed.
//
// If unspecified, the default value is "Enabled"
//
// +kubebuilder:validation:Enum="Disabled";"Enabled"
// +kubebuilder:default="Enabled"
// +optional
Availability string `json:"availability,omitempty"`
LalatenduMohanty marked this conversation as resolved.
Show resolved Hide resolved
}

// ClusterCatalogStatus defines the observed state of ClusterCatalog
Expand Down
2 changes: 2 additions & 0 deletions cmd/manager/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ func main() {

localStorage = storage.LocalDir{RootDir: storeDir, BaseURL: baseStorageURL}

// Config for the the catalogd web server
catalogServerConfig := serverutil.CatalogServerConfig{
ExternalAddr: externalAddr,
CatalogAddr: catalogServerAddr,
Expand All @@ -268,6 +269,7 @@ func main() {
LocalStorage: localStorage,
}

// Start the catalogd web server
LalatenduMohanty marked this conversation as resolved.
Show resolved Hide resolved
err = serverutil.AddCatalogServerToManager(mgr, catalogServerConfig, cw)
if err != nil {
setupLog.Error(err, "unable to configure catalog server")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,21 @@ spec:
spec:
description: ClusterCatalogSpec defines the desired state of ClusterCatalog
properties:
availability:
default: Enabled
description: |-
Availability is an optional field that allows users to define whether the ClusterCatalog is utilized by the operator-controller.

Allowed values are : ["Enabled", "Disabled"].
If set to "Enabled", the catalog will be used for updates, serving contents, and package installations.

If set to "Disabled", catalogd will stop serving the catalog and the cached data will be removed.

If unspecified, the default value is "Enabled"
enum:
- Disabled
- Enabled
type: string
priority:
default: 0
description: |-
Expand Down
37 changes: 37 additions & 0 deletions internal/controllers/core/clustercatalog_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ func (r *ClusterCatalogReconciler) Reconcile(ctx context.Context, req ctrl.Reque
if err := r.Client.Get(ctx, req.NamespacedName, &existingCatsrc); err != nil {
return ctrl.Result{}, client.IgnoreNotFound(err)
}

reconciledCatsrc := existingCatsrc.DeepCopy()
res, reconcileErr := r.reconcile(ctx, reconciledCatsrc)

Expand Down Expand Up @@ -157,6 +158,31 @@ func (r *ClusterCatalogReconciler) SetupWithManager(mgr ctrl.Manager) error {
func (r *ClusterCatalogReconciler) reconcile(ctx context.Context, catalog *v1alpha1.ClusterCatalog) (ctrl.Result, error) {
l := log.FromContext(ctx)

// Check if the catalog availability is set to disabled, if true then
// unset content URL, delete it from the cache and set appropriate status
if catalog.Spec.Availability == v1alpha1.AvailabilityDisabled {
LalatenduMohanty marked this conversation as resolved.
Show resolved Hide resolved
// Delete the catalog from local cache
if err := r.Storage.Delete(catalog.Name); err != nil {
updateStatusProgressing(&catalog.Status, catalog.GetGeneration(), err)
return ctrl.Result{}, err
}

// Set status.conditions[type=Serving] to False, unset status.contentURL and
// update status.lastUnpacked
updateStatusNotServing(&catalog.Status, catalog.GetGeneration())
LalatenduMohanty marked this conversation as resolved.
Show resolved Hide resolved
if err := r.Unpacker.Cleanup(ctx, catalog); err != nil {
updateStatusProgressing(&catalog.Status, catalog.GetGeneration(), err)
return ctrl.Result{}, err
}
r.deleteStoredCatalog(catalog.Name)

// Set status.conditions[type=Progressing] to False as we are done with
// all that needs to be done with the catalog
updateStatusCatalogDisabled(&catalog.Status, catalog.GetGeneration())

return ctrl.Result{}, nil
}

finalizeResult, err := r.finalizers.Finalize(ctx, catalog)
if err != nil {
return ctrl.Result{}, err
Expand Down Expand Up @@ -315,6 +341,17 @@ func updateStatusServing(status *v1alpha1.ClusterCatalogStatus, result source.Re
})
}

func updateStatusCatalogDisabled(status *v1alpha1.ClusterCatalogStatus, generation int64) {
progressingCond := metav1.Condition{
Type: v1alpha1.TypeProgressing,
Status: metav1.ConditionFalse,
Reason: v1alpha1.ReasonDisabled,
Message: "Catalog availability is set to Disabled",
ObservedGeneration: generation,
}
meta.SetStatusCondition(&status.Conditions, progressingCond)
}

func updateStatusNotServing(status *v1alpha1.ClusterCatalogStatus, generation int64) {
status.ResolvedSource = nil
status.ContentURL = ""
Expand Down