Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Bump ClusterCatalog API to v1 #380

Merged

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Sep 6, 2024

Bumps ClusterCatalog API to v1

Closes #341

@perdasilva perdasilva requested a review from a team as a code owner September 6, 2024 14:54
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes missing coverage. Please review.

Project coverage is 38.23%. Comparing base (20acf03) to head (42e7239).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rnal/controllers/core/clustercatalog_controller.go 87.50% 4 Missing ⚠️
internal/source/containers_image.go 71.42% 1 Missing and 1 partial ⚠️
api/v1/zz_generated.deepcopy.go 0.00% 1 Missing ⚠️
cmd/manager/main.go 0.00% 1 Missing ⚠️
internal/webhook/cluster_catalog_webhook.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files          15       15           
  Lines        1224     1224           
=======================================
  Hits          468      468           
  Misses        706      706           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 5aadf86 to cd3937b Compare September 6, 2024 16:57
@perdasilva
Copy link
Contributor Author

/hold until we are ready to release

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@perdasilva perdasilva marked this pull request as draft September 12, 2024 11:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from cd3937b to 33193d1 Compare September 25, 2024 15:23
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 33193d1 to 1e4f441 Compare October 16, 2024 08:20
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 16, 2024
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 1e4f441 to eaac7d8 Compare November 7, 2024 16:56
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch 2 times, most recently from 5a47124 to 541d79c Compare November 7, 2024 17:35
test/e2e/unpack_test.go Outdated Show resolved Hide resolved
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 541d79c to 04a98ea Compare November 7, 2024 17:56
@perdasilva perdasilva changed the title [HOLD] ⚠️ Bump ClusterCatalog API to v1 ⚠️ Bump ClusterCatalog API to v1 Nov 7, 2024
@perdasilva perdasilva marked this pull request as ready for review November 7, 2024 17:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@everettraven everettraven added this pull request to the merge queue Nov 8, 2024
@joelanford joelanford removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
Merged via the queue into operator-framework:main with commit 2f96c57 Nov 8, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

promote API from v1alpha1 to v1
4 participants