Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for catalog-operator and packageserver pods being in CrashLoopBackOff if updateStrategy is empty #340

Conversation

rashmigottipati
Copy link
Member

Description:

  • dont poll if updateStrategy and any of its child references are empty
  • cover the panic by adding nil protection checks along the pointer stack of updateStrategy struct

…BackOff if updateStrategy is empty

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@openshift-ci openshift-ci bot requested review from benluddy and exdx June 7, 2024 15:19
Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rashmigottipati
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rashmigottipati rashmigottipati requested review from joelanford and removed request for benluddy and exdx June 7, 2024 15:19
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 39.23%. Comparing base (d6920a4) to head (82308c6).

Files Patch % Lines
pkg/operators/v1alpha1/catalogsource_types.go 57.14% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   39.43%   39.23%   -0.20%     
==========================================
  Files          56       56              
  Lines        4516     4521       +5     
==========================================
- Hits         1781     1774       -7     
- Misses       2581     2591      +10     
- Partials      154      156       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rashmigottipati rashmigottipati force-pushed the bugfix-updateStrategy branch 2 times, most recently from ab597a9 to 4e5c8dc Compare June 8, 2024 00:10
@rashmigottipati rashmigottipati marked this pull request as draft June 8, 2024 00:23
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2024
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati rashmigottipati force-pushed the bugfix-updateStrategy branch from 4e5c8dc to 82308c6 Compare June 8, 2024 00:30
@perdasilva
Copy link
Contributor

closing as this is no longer required

@perdasilva perdasilva closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants