Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transmissision: remove build dependency on nodejs #25715

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

icegood
Copy link
Contributor

@icegood icegood commented Jan 9, 2025

Have no idea why such dependency was added.
No documentation from transmission that they need
such dependency on build time. On the other hand
saves vast of time during build

Maintainer: me / @<github-user> (find it by checking history of the package Makefile)
Compile tested: (put here arch, model, OpenWrt version)
Run tested: (put here arch, model, OpenWrt version, tests done)

Description:

Have no idea why such dependency was added.
No documentation from transmission that they need
such dependency on build time. On the other hand
saves vast of time during build

Signed-off-by: Serhii Ivanov <icegood1980@gmail.com>
@BKPepe
Copy link
Member

BKPepe commented Jan 9, 2025

This dependency was added by @dangowrt in 96fd2dc. Maybe he knows more about this one. :-)

@neheb
Copy link
Contributor

neheb commented Jan 15, 2025

This is definitely a mistake.

@neheb neheb merged commit a06829b into openwrt:master Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants