Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To v0.9.0; full reformat & check with ruff #86

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

pgleeson
Copy link
Member

@pgleeson pgleeson commented Dec 3, 2024

No description provided.

@nanoman657
Copy link
Contributor

@pgleeson OpenWorm is a very interesting project, and I would like to help out over at least 1Q25. It might be helpful to break up this change into smaller chunks that are more easily reviewed. I would be happy to help do this and write some tests to validate the expected behavior.

I say this because Ruff has commented out some functions that you may wish to keep or otherwise reformat:

c302/c302/c302_utils.py

Lines 85 to 86 in a3d4664

# def plots_prof(a_n, info, cells, dt):
# cProfile.run("real_plots(a_n, info, cells, dt)")

c302/c302/CompareMain.py

Lines 258 to 263 in a3d4664

def typeMapping(cols1, cols2, indexName1, indexName2):
# list1 = ["GapJunction", "Send"]
# list2 = ["EJ", "NMJ", "R", "Rp", "S", "Sp"]
# type1 = cols1[indexName1[2]]
# type2 = cols2[indexName2[2]]
pass

I'm sure you're on holiday now, so we can discuss upon your return. Happy New Year!

@pgleeson
Copy link
Member Author

pgleeson commented Jan 7, 2025

Thanks for your contributions @nanoman657. I'm getting back into all this this week, and will try to look over your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants