Skip to content

Commit

Permalink
github: Update versions of action dependencies (Node.js 20).
Browse files Browse the repository at this point in the history
checkout@v3, cache@v3 and setup-python@v4 are using outdated Node.js 16
which is now deprecated in GHA [1], so these actions will stop working
soon.

Updating to most recent major versions with Node.js 20.  This stops GHA
from throwing warnings in every build.

[1] https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

While at it also updating upload-artifact version to the latest version.
Removed versions from the comment as the general behavior of this
action regarding symlinks and wildcards doesn't seem to change between
versions much.

Acked-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
  • Loading branch information
igsilya committed Jan 29, 2024
1 parent f6757eb commit 49e64f1
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

steps:
- name: checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: update PATH
run: |
Expand Down Expand Up @@ -45,14 +45,14 @@ jobs:

- name: cache
id: dpdk_cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: dpdk-dir
key: ${{ steps.gen_dpdk_key.outputs.key }}

- name: set up python
if: steps.dpdk_cache.outputs.cache-hit != 'true'
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.9'

Expand Down Expand Up @@ -166,21 +166,21 @@ jobs:

steps:
- name: checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: update PATH
run: |
echo "$HOME/bin" >> $GITHUB_PATH
echo "$HOME/.local/bin" >> $GITHUB_PATH
- name: set up python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.9'

- name: cache
if: matrix.dpdk != '' || matrix.dpdk_shared != ''
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: dpdk-dir
key: ${{ needs.build-dpdk.outputs.dpdk_key }}
Expand All @@ -206,9 +206,9 @@ jobs:
- name: copy logs on failure
if: failure() || cancelled()
run: |
# upload-artifact@v2 throws exceptions if it tries to upload socket
# upload-artifact throws exceptions if it tries to upload socket
# files and we could have some socket files in testsuite.dir.
# Also, upload-artifact@v2 doesn't work well enough with wildcards.
# Also, upload-artifact doesn't work well enough with wildcards.
# So, we're just archiving everything here to avoid any issues.
mkdir logs
cp config.log ./logs/
Expand All @@ -217,7 +217,7 @@ jobs:
- name: upload logs on failure
if: failure() || cancelled()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: logs-linux-${{ join(matrix.*, '-') }}
path: logs.tgz
Expand All @@ -236,13 +236,13 @@ jobs:

steps:
- name: checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: update PATH
run: |
echo "$HOME/bin" >> $GITHUB_PATH
echo "$HOME/.local/bin" >> $GITHUB_PATH
- name: set up python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.9'
- name: install dependencies
Expand All @@ -253,7 +253,7 @@ jobs:
run: ./.ci/osx-build.sh
- name: upload logs on failure
if: failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: logs-osx-clang---disable-ssl
path: config.log
Expand All @@ -277,7 +277,7 @@ jobs:

steps:
- name: checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: update PATH
run: |
Expand All @@ -299,7 +299,7 @@ jobs:
run: ./.ci/linux-build.sh

- name: upload deb packages
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: deb-packages-${{ matrix.dpdk }}-dpdk
path: '/home/runner/work/ovs/*.deb'
Expand All @@ -315,7 +315,7 @@ jobs:

steps:
- name: checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: install dependencies
run: |
dnf install -y rpm-build dnf-plugins-core
Expand All @@ -334,7 +334,7 @@ jobs:
run: dnf install -y rpm/rpmbuild/RPMS/*/*.rpm

- name: upload rpm packages
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: rpm-packages
path: |
Expand Down

0 comments on commit 49e64f1

Please sign in to comment.