Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace from kuttl assert #222

Conversation

cescgina
Copy link
Contributor

@cescgina cescgina commented Nov 1, 2023

Remove any explicit check for namespace in the kuttl assert file, since
the tests can be run in different namespaces.

Remove any explicit check for namespace in the kuttl assert file, since
the tests can be run in different namespaces.
@paramite
Copy link
Contributor

paramite commented Nov 1, 2023

/lgtm

@jlarriba
Copy link
Collaborator

jlarriba commented Nov 1, 2023

/approve

Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina, jlarriba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 1, 2023
@openshift-ci openshift-ci bot merged commit 730aad2 into openstack-k8s-operators:main Nov 1, 2023
3 checks passed
@cescgina cescgina deleted the remove_namespaces_kuttl_assert branch November 1, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants