Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pushgateway #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raukadah
Copy link
Contributor

It will help to push custom metrics

It will help to push custom metrics

Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
@openshift-ci openshift-ci bot requested review from paramite and yadneshk January 13, 2025 15:30
Copy link

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raukadah
Once this PR has been reviewed and has the lgtm label, please assign vyzigold for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paramite
Copy link
Contributor

Can you please elaborate more about the reasoning of the pushgateway deployment? sg-core has very similar functionality, but much better behaviour than pushgateway. Maybe you're trying to solve a problem, which is already solved by sg-core

@raukadah
Copy link
Contributor Author

Can you please elaborate more about the reasoning of the pushgateway deployment? sg-core has very similar functionality, but much better behaviour than pushgateway. Maybe you're trying to solve a problem, which is already solved by sg-core

Thank you @paramite for the question.
Recently in openstack watcher project, we are about to merge [prometheus datasource](https://review.opendev.org/c/openstack/watcher/+/934423) (which will pull metrics from ceilometer and node_exporter) to perform cloud optimization.

In order to test prometheus datasource in watcher-tempest-plugin. We need a server where we can push custom counter metrics(like: node_cpu_seconds_total) and prometheus server will scrape these data from that server during test run. Tempest will perform aggregation on doing a query on prometheus server and then perform optimization via tempest tests.

In order to push metrics with custom fields, we wanted to use pushgateway as a server and use the same in the tests. That's why I proposed this pr to install pushgateway on the devstack environment.
Do let me know if we can achieve the same with sg-core. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants