Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a flag to toggle podman build cache while building images #532

Closed

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Oct 24, 2023

No description provided.

@rebtoor rebtoor requested review from dprince and abays October 24, 2023 10:19
@openshift-ci openshift-ci bot requested review from frenzyfriday and viroel October 24, 2023 10:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rebtoor
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprince
Copy link
Contributor

dprince commented Oct 24, 2023

@rebtoor should we make this configurable? It seems caching could be useful in some contexts right?

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 25, 2023

@rebtoor should we make this configurable? It seems caching could be useful in some contexts right?

Yeah, you're right.

BTW this patch didn't help with the problem that we faced so it could be an (unrequired) improvement. Let me push the fix.

Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@rebtoor rebtoor force-pushed the disable-build-cache branch from ac368ec to f816593 Compare October 25, 2023 15:32
@rebtoor rebtoor changed the title Disable cache while building images Add the possibility to toggle podman build cache while building images Oct 25, 2023
@rebtoor rebtoor changed the title Add the possibility to toggle podman build cache while building images Added a flag to toggle podman build cache while building images Oct 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2023

@rebtoor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl f816593 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dprince
Copy link
Contributor

dprince commented Oct 25, 2023

what about just a more generic PODMAN_BUILD_OPTS, similar to the already existing BUNDLE_METADATA_OPTS

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rebtoor rebtoor closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants