Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the JUnitXML reporting #376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix the JUnitXML reporting #376

wants to merge 2 commits into from
+12 −2

Conversation

tosky
Copy link
Contributor

@tosky tosky commented Dec 12, 2024 •
edited
Loading

  • fix the type (it is 'xml' lowercase, not uppercase);
  • tune the name a bit to highlight it is a report;
  • add the new reportGranularity parameter which will be supported by kuttl 1.20 and will restore the pre-1.17 JUnitXML format (granularity by test case, instead of by step).

Depends-On: openstack-k8s-operators/ci-framework#2598
Depends-On: openstack-k8s-operators/install_yamls#973

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tosky
Once this PR has been reviewed and has the lgtm label, please assign gouthampacha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tosky
Copy link
Contributor Author

tosky commented Dec 12, 2024

recheck

@tosky tosky marked this pull request as ready for review December 12, 2024 13:56
@tosky
Copy link
Contributor Author

tosky commented Dec 12, 2024

This is still WIP, but I have no idea how to trigger the zuul jobs otherwise.

@tosky
Copy link
Contributor Author

tosky commented Dec 13, 2024

recheck

2 similar comments
@tosky
Copy link
Contributor Author

tosky commented Dec 13, 2024

recheck

@tosky
Copy link
Contributor Author

tosky commented Dec 14, 2024

recheck

@tosky tosky mentioned this pull request Dec 16, 2024
Merged
@tosky
Copy link
Contributor Author

tosky commented Dec 16, 2024

recheck

@tosky
Fix the JUnitXML reporting
4f1e1e2 
- fix the type (it is 'xml' lowercase, not uppercase);
- tune the name a bit to highlight it is a report;
- add the new reportGranularity parameter which is supported
  by kuttl 0.20.0 and will restore the pre-1.17 JUnitXML format
  (granularity by test case, instead of by step).

Depends-On: openstack-k8s-operators/ci-framework#2598
Signed-off-by: Luigi Toscano <ltoscano@redhat.com>
@tosky tosky force-pushed the kuttl-fix-xml-reporting branch from 8f183c2 to 4f1e1e2 Compare December 16, 2024 11:55
@tosky
Fix the kuttl zuul job to also run on significant changes
be8242e 
Previously the changes to kuttl-test.yaml itself were ignored.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c9cda98da1d84f78924806cb88f16978

❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0007705142 failed in 0s
⚠️ manila-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ manila-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@tosky
Copy link
Contributor Author

tosky commented Dec 16, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5a555c2a02c842019ad072433fa5b71a

❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0007705186 failed in 0s
⚠️ manila-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ manila-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@tosky: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/manila-operator-build-deploy-kuttl be8242e link true /test manila-operator-build-deploy-kuttl
ci/prow/manila-operator-build-deploy-tempest be8242e link true /test manila-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tosky
Copy link
Contributor Author

tosky commented Dec 16, 2024

recheck

1 similar comment
@tosky
Copy link
Contributor Author

tosky commented Dec 17, 2024

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@stuggi stuggi Awaiting requested review from stuggi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tosky